Skip to content

Commit b487384

Browse files
committed
♻️ Converted AemProxyAfSubmission to use constructor injection.
It was @Autowired as a holdover from when it used JAX-RS Jersey implementation, but that is not required for Spring. Constructor injection is to be preferred over being @Autowired.
1 parent c1a7ecb commit b487384

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

spring/fluentforms-spring-boot-autoconfigure/src/main/java/com/_4point/aem/fluentforms/spring/AemProxyAfSubmission.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
import org.slf4j.Logger;
1616
import org.slf4j.LoggerFactory;
17-
import org.springframework.beans.factory.annotation.Autowired;
1817
import org.springframework.boot.autoconfigure.web.client.RestClientSsl;
1918
import org.springframework.boot.ssl.NoSuchSslBundleException;
2019
import org.springframework.http.HttpEntity;
@@ -62,8 +61,11 @@ public class AemProxyAfSubmission {
6261
private final static Logger logger = LoggerFactory.getLogger(AemProxyAfSubmission.class);
6362
private static final String CONTENT_FORMS_AF = "/content/forms/af/";
6463

65-
@Autowired
66-
SpringAfSubmitProcessor submitProcessor;
64+
private final SpringAfSubmitProcessor submitProcessor;
65+
66+
AemProxyAfSubmission(SpringAfSubmitProcessor submitProcessor) {
67+
this.submitProcessor = submitProcessor;
68+
}
6769

6870
@PostMapping(path = CONTENT_FORMS_AF + "{*remainder}", consumes = MediaType.MULTIPART_FORM_DATA_VALUE, produces = MediaType.ALL_VALUE)
6971
public ResponseEntity<byte[]> proxySubmitPost(@PathVariable("remainder") String remainder, /* @HeaderParam(CorrelationId.CORRELATION_ID_HDR) final String correlationIdHdr,*/ @RequestHeader HttpHeaders headers, final MultipartHttpServletRequest inFormData) {

spring/fluentforms-spring-boot-autoconfigure/src/main/java/com/_4point/aem/fluentforms/spring/AemProxyAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ AemProxyEndpoint aemProxyEndpoint(AemConfiguration aemConfig, AemProxyConfigurat
4949
}
5050

5151
@Bean
52-
AemProxyAfSubmission aemProxyAfSubmission() {
53-
return new AemProxyAfSubmission();
52+
AemProxyAfSubmission aemProxyAfSubmission(SpringAfSubmitProcessor submitProcessor) {
53+
return new AemProxyAfSubmission(submitProcessor);
5454
}
5555

5656
/**

0 commit comments

Comments
 (0)