Skip to content

EMCAL: Delete unused files#15026

Open
vkucera wants to merge 1 commit intoAliceO2Group:devfrom
vkucera:unused-emcal
Open

EMCAL: Delete unused files#15026
vkucera wants to merge 1 commit intoAliceO2Group:devfrom
vkucera:unused-emcal

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Feb 5, 2026

See #14973

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member

ktf commented Feb 9, 2026

@ihrivnac the doxymodules.h files are actually required, no?

@ktf
Copy link
Member

ktf commented Feb 10, 2026

@vkucera I am pretty convinced the doxymodules.h are needed.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 10, 2026

@vkucera I am pretty convinced the doxymodules.h are needed.

Are you sure? There are only 3 of them in the entire repo.

@jokonig
Copy link
Collaborator

jokonig commented Feb 10, 2026

Hi @vkucera
Thanks for this cleanup of the EMCal code! (And sorry for my late response)
I am not sure about the doxymodules. This is something Markus did, and I don't know exactly how they work.
I actually did not realize that the test for the badChannelScale factors is not used in the test. Could you leave it in, and I will properly implement it in the tests?

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 8bc9df3 at 2026-02-12 11:43:

## sw/BUILD/O2-RTC-test-latest/log
[ERROR] Error Opening cagpu library for GPU Tracker (libO2GPUTrackingCUDA.so)
[ERROR] Error: Could not load GPUReconstruction for specified device: CUDA (2)

Full log here.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 12, 2026

@ktf @ihrivnac Does someone know what the doxymodules.h files are for?
From the name I assume it is something related to the Doxygen documentation but then it seems suspicious to me that there are only 3 of them, while I would expect them to appear in other directories too, at least for the other detectors.

@ktf
Copy link
Member

ktf commented Feb 12, 2026

I vaguely remember they are for customising the various section contents? Maybe only EMCAL ever bothered having something different from the default? @ihrivnac do you remember?

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 12, 2026

@jokonig I have removed testBadChannelScaleFactors.cxx and the doxymodules.h files from the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants