Merge pull request #67 from nezaniel/php84Compatibility

PHP 8.4 compatibility

Author: dlubitz

Classes/Job/JobManager.php

@@ -258,7 +258,7 @@ protected function emitMessageFinished(QueueInterface $queue, Message $message):
      * @Flow\Signal
      * @api
      */
-    protected function emitMessageReleased(QueueInterface $queue, Message $message, array $releaseOptions, \Exception $jobExecutionException = null): void
+    protected function emitMessageReleased(QueueInterface $queue, Message $message, array $releaseOptions, ?\Exception $jobExecutionException = null): void
     {
     }
 
@@ -272,7 +272,7 @@ protected function emitMessageReleased(QueueInterface $queue, Message $message,
      * @Flow\Signal
      * @api
      */
-    protected function emitMessageFailed(QueueInterface $queue, Message $message, \Exception $jobExecutionException = null): void
+    protected function emitMessageFailed(QueueInterface $queue, Message $message, ?\Exception $jobExecutionException = null): void
     {
     }
 

Classes/Queue/FakeQueue.php

@@ -98,15 +98,15 @@ public function submit($payload, array $options = []): string
     /**
      * @inheritdoc
      */
-    public function waitAndTake(int $timeout = null): Message
+    public function waitAndTake(?int $timeout = null): Message
     {
         throw new \BadMethodCallException('The FakeQueue does not support reserving of messages.' . chr(10) . 'It is not required to use a worker for this queue as messages are handled immediately upon submission.', 1468425275);
     }
 
     /**
      * @inheritdoc
      */
-    public function waitAndReserve(int $timeout = null): Message
+    public function waitAndReserve(?int $timeout = null): Message
     {
         throw new \BadMethodCallException('The FakeQueue does not support reserving of messages.' . chr(10) . 'It is not required to use a worker for this queue as messages are handled immediately upon submission.', 1468425280);
     }

README.md

@@ -373,7 +373,7 @@ class Package extends BasePackage
 
         $dispatcher->connect(
             JobManager::class, 'messageFailed',
-            function(QueueInterface $queue, Message $message, \Exception $jobExecutionException = null) use ($bootstrap) {
+            function(QueueInterface $queue, Message $message, ?\Exception $jobExecutionException = null) use ($bootstrap) {
                 $additionalData = [
                     'queue' => $queue->getName(),
                     'message' => $message->getIdentifier()

Tests/Unit/Fixtures/TestQueue.php

@@ -115,7 +115,7 @@ public function submit($payload, array $options = []): string
     /**
      * @inheritdoc
      */
-    public function waitAndTake(int $timeout = null): ?Message
+    public function waitAndTake(?int $timeout = null): ?Message
     {
         $message = $this->reserveMessage($timeout);
         if ($message === null) {
@@ -129,16 +129,16 @@ public function waitAndTake(int $timeout = null): ?Message
     /**
      * @inheritdoc
      */
-    public function waitAndReserve(int $timeout = null): ?Message
+    public function waitAndReserve(?int $timeout = null): ?Message
     {
         return $this->reserveMessage($timeout);
     }
 
     /**
-     * @param int $timeout
+     * @param int|null $timeout
      * @return Message
      */
-    protected function reserveMessage(int $timeout = null): ?Message
+    protected function reserveMessage(?int $timeout = null): ?Message
     {
         if ($timeout === null) {
             $timeout = $this->defaultTimeout;