Merge pull request #89 from Shopify/cp-bump-5-11

Bump dep to 5.11 and fix broken windows

Author: charlespwd

.github/workflows/ruby.yml

@@ -8,7 +8,7 @@ permissions:
   contents: read
 jobs:
   test:
-    runs-on: shopify-ubuntu-latest
+    runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
     - name: Ruby

.gitignore

@@ -10,3 +10,4 @@
 /spec/reports/
 /tmp/
 /Gemfile.lock
+.claude

CLAUDE.md

@@ -0,0 +1,71 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## What This Project Is
+
+liquid-spec is a test suite for the Liquid templating language. It captures test cases from the reference Shopify/liquid implementation and can verify that other Liquid implementations produce identical output.
+
+## Common Commands
+
+```bash
+# Run all tests
+bundle exec rake test
+
+# Run a single test file
+bundle exec ruby -Ilib:test test/liquid_ruby_test.rb
+
+# Run a specific test method
+bundle exec ruby -Ilib:test test/liquid_ruby_test.rb -n test_method_name
+
+# Generate specs from Shopify/liquid (clones repo to tmp/, runs tests, captures output)
+bundle exec rake generate
+
+# Generate only liquid_ruby specs
+bundle exec rake generate:liquid_ruby
+
+# Generate only standard_filters specs
+bundle exec rake generate:standard_filters
+```
+
+## Architecture
+
+### Spec Generation Flow
+
+1. `rake generate` clones Shopify/liquid to `tmp/liquid/` at the version matching the liquid gem dependency
+2. Patches are injected into the cloned repo's test helper to capture test data during execution
+3. Tests run in the cloned repo, writing captured specs to `tmp/liquid-ruby-capture.yml`
+4. Captured data is formatted and written to `specs/liquid_ruby/*.yml`
+
+### Key Components
+
+- **`Liquid::Spec::Unit`** (`lib/liquid/spec/unit.rb`): Struct representing a single test case with fields: name, expected, template, environment, filesystem, error_mode, etc.
+
+- **`Liquid::Spec::Source`** (`lib/liquid/spec/source.rb`): Factory for loading specs from different formats (YAML, text, directory-based)
+
+- **`Liquid::Spec::TestGenerator`** (`lib/liquid/spec/test_generator.rb`): Dynamically generates test methods on a test class from spec sources. Groups specs by class name prefix (e.g., `AssignTest#test_foo` creates `AssignTest` subclass).
+
+- **`Liquid::Spec::Adapter`** (`lib/liquid/spec/adapter/`): Adapters render templates. `Default` returns expected values; `LiquidRuby` actually renders with the liquid gem.
+
+- **`Liquid::Spec::Assertions`** (`lib/liquid/spec/assertions.rb`): Module factory that provides `assert_parity_for_spec` comparing expected adapter output against actual adapter output.
+
+### Spec File Format (YAML)
+
+```yaml
+- name: TestClass#test_description_hash
+  template: "{{ foo | upcase }}"
+  environment:
+    foo: bar
+  expected: "BAR"
+  error_mode: :lax  # optional
+  render_errors: false
+  filesystem:       # optional, for include/render tags
+    snippet: "content"
+```
+
+### Directory Structure
+
+- `specs/liquid_ruby/` - Core Liquid language specs generated from Shopify/liquid tests
+- `specs/dawn/` - Shopify Dawn theme section rendering specs
+- `lib/liquid/spec/deps/` - Patches applied to Shopify/liquid during spec generation
+- `tasks/` - Rake tasks for spec generation

lib/liquid/spec/deps/liquid_ruby.rb

@@ -138,6 +138,26 @@ def to_s
   end
 end
 
+class CustomToLiquidDrop < Liquid::Drop
+  def initialize(value)
+    @value = value
+  end
+
+  def to_liquid
+    @value
+  end
+end
+
+class HashWithCustomToS < Hash
+  def to_s
+    "kewl"
+  end
+end
+
+class HashWithoutCustomToS < Hash
+end
+
+
 class StringDrop < Liquid::Drop
   include Comparable
 

lib/liquid/spec/deps/shopify_liquid_patch.rb

@@ -30,7 +30,7 @@ def assert_template_result(expected, template, assigns = {},
       digest << template
       digest << data.to_s
       digest = digest.hexdigest[0..7]
-      test_name = "#{class_name}##{name}_#{digest}"
+      test_name = "#{self.class.name}##{name}_#{digest}"
       data = { "name" => test_name }.merge(data).compact
       test_data = caller
         .select { |line| line.match(%r{liquid-spec/tmp/liquid/test/.*_test\.rb}) }

liquid-spec.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
     end
   end
 
-  spec.add_dependency("liquid", "~> 5.8.7")
+  spec.add_dependency("liquid", "~> 5.11.0")
   spec.add_dependency("super_diff", "~> 0.12.1")
   spec.add_dependency("timecop")
   spec.add_dependency("tty-box")