Skip to content

run.sh and run-helper.sh don't return the exit codes from Runner.Listener #4164

@shaperilio

Description

@shaperilio

Describe the bug
run.sh does not return the exit code from run-helper.sh. It addresses a return code of 2 and otherwise always returns 0. run-helper.sh does something similar. This makes the return code largely useless as you must always check stdout/err to see what happened.

Expected behavior
this line should be exit $returnCode. Similarly, several conditionals here return code 0 when they really shouldn't - at the very least, maybe this line should change?

That way, if I'm launching this from something expecting to report an error if execution did not succeed, it will actually know.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions