diff --git a/charts/openstack-hypervisor-operator/values.yaml b/charts/openstack-hypervisor-operator/values.yaml index a859cd8e..98cf8a30 100644 --- a/charts/openstack-hypervisor-operator/values.yaml +++ b/charts/openstack-hypervisor-operator/values.yaml @@ -4,8 +4,8 @@ controllerManager: - --metrics-bind-address=:8443 - --leader-elect - --health-probe-bind-address=:8081 - - --certificate-issuer-name=${CERTIFICATE_ISSUER_NAME} - - --label-selector=${LABEL_SELECTOR} + - --certificate-issuer-name=$(CERTIFICATE_ISSUER_NAME) + - --label-selector=$(LABEL_SELECTOR) containerSecurityContext: allowPrivilegeEscalation: false capabilities: diff --git a/cmd/main.go b/cmd/main.go index 4ca72faf..00eba067 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -35,7 +35,6 @@ import ( corev1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/selection" utilruntime "k8s.io/apimachinery/pkg/util/runtime" clientgoscheme "k8s.io/client-go/kubernetes/scheme" ctrl "sigs.k8s.io/controller-runtime" @@ -167,8 +166,7 @@ func main() { var cacheOptions cache.Options if global.LabelSelector != "" { setupLog.Info("setting up cache with label selector", "selector", global.LabelSelector) - selector := labels.NewSelector() - req, err := labels.NewRequirement(global.LabelSelector, selection.Exists, nil) + selector, err := labels.Parse(global.LabelSelector) if err != nil { setupLog.Error(err, "unable to parse label selector") os.Exit(1) @@ -177,10 +175,10 @@ func main() { cacheOptions = cache.Options{ ByObject: map[client.Object]cache.ByObject{ &corev1.Node{}: { - Label: selector.Add(*req), + Label: selector, }, &kvmv1.Hypervisor{}: { - Label: selector.Add(*req), + Label: selector, }, }, } diff --git a/config/manager/manager.yaml b/config/manager/manager.yaml index 666ba653..5641de62 100644 --- a/config/manager/manager.yaml +++ b/config/manager/manager.yaml @@ -61,8 +61,8 @@ spec: - args: - --leader-elect - --health-probe-bind-address=:8081 - - --certificate-issuer-name=${CERTIFICATE_ISSUER_NAME} - - --label-selector=${LABEL_SELECTOR} + - --certificate-issuer-name=$(CERTIFICATE_ISSUER_NAME) + - --label-selector=$(LABEL_SELECTOR) env: - name: OS_AUTH_URL - name: OS_PROJECT_DOMAIN_NAME