Skip to content

Commit 1ee260d

Browse files
authored
Merge branch 'main' into prek
2 parents 9b10446 + 9262835 commit 1ee260d

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/smokeshow.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,15 @@ env:
1313

1414
jobs:
1515
smokeshow:
16-
if: ${{ github.event.workflow_run.conclusion == 'success' }}
1716
runs-on: ubuntu-latest
1817
steps:
1918
- uses: actions/checkout@v6
2019
- uses: actions/setup-python@v6
2120
with:
22-
python-version: '3.9'
21+
python-version: '3.13'
2322
- name: Setup uv
2423
uses: astral-sh/setup-uv@v7
2524
with:
26-
version: "0.4.15"
27-
enable-cache: true
2825
cache-dependency-glob: |
2926
requirements**.txt
3027
pyproject.toml
@@ -48,7 +45,7 @@ jobs:
4845
done
4946
env:
5047
SMOKESHOW_GITHUB_STATUS_DESCRIPTION: Coverage {coverage-percentage}
51-
SMOKESHOW_GITHUB_COVERAGE_THRESHOLD: 95
48+
SMOKESHOW_GITHUB_COVERAGE_THRESHOLD: 99
5249
SMOKESHOW_GITHUB_CONTEXT: coverage
5350
SMOKESHOW_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5451
SMOKESHOW_GITHUB_PR_HEAD_SHA: ${{ github.event.workflow_run.head_sha }}

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,14 +124,14 @@ jobs:
124124
run: uv pip install -r requirements-tests.txt
125125
- run: ls -la coverage
126126
- run: coverage combine coverage
127-
- run: coverage report
128127
- run: coverage html --title "Coverage for ${{ github.sha }}"
129128
- name: Store coverage HTML
130129
uses: actions/upload-artifact@v5
131130
with:
132131
name: coverage-html
133132
path: htmlcov
134133
include-hidden-files: true
134+
- run: coverage report --fail-under=99
135135

136136
# https://github.com/marketplace/actions/alls-green#why
137137
alls-green: # This job does nothing and is only used for the branch protection

docs/release-notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
### Internal
1212

13+
* 👷 Configure coverage, error on main tests, don't wait for Smokeshow. PR [#1683](https://github.com/fastapi/sqlmodel/pull/1683) by [@YuriiMotov](https://github.com/YuriiMotov).
14+
* 👷 Run Smokeshow always, even on test failures. PR [#1682](https://github.com/fastapi/sqlmodel/pull/1682) by [@YuriiMotov](https://github.com/YuriiMotov).
1315
* ⬆ Bump ruff from 0.14.6 to 0.14.8. PR [#1667](https://github.com/fastapi/sqlmodel/pull/1667) by [@dependabot[bot]](https://github.com/apps/dependabot).
1416
*[pre-commit.ci] pre-commit autoupdate. PR [#1662](https://github.com/fastapi/sqlmodel/pull/1662) by [@pre-commit-ci[bot]](https://github.com/apps/pre-commit-ci).
1517
* ⬆ Bump actions/checkout from 5 to 6. PR [#1656](https://github.com/fastapi/sqlmodel/pull/1656) by [@dependabot[bot]](https://github.com/apps/dependabot).

0 commit comments

Comments
 (0)