diff --git a/README.md b/README.md index 2ef618a4d3..e599f42f60 100644 --- a/README.md +++ b/README.md @@ -162,12 +162,5 @@ Testing ------- Plotnine has tests that generate images which are compared to baseline images known -to be correct. To generate images that are consistent across all systems you have -to install matplotlib from source. You can do that with ``pip`` using the command. - -```console -$ pip install matplotlib --no-binary matplotlib -``` - -Otherwise there may be small differences in the text rendering that throw off the -image comparisons. +to be correct. There may be small differences in the text rendering that throw off the +image comparisons, and the tests allow some very small differences. diff --git a/doc/changelog.qmd b/doc/changelog.qmd index 126db6c7c4..346d84ef2e 100644 --- a/doc/changelog.qmd +++ b/doc/changelog.qmd @@ -48,6 +48,11 @@ title: Changelog [](:class:`~plotnine.geom_point`) when the shape is mapped to variable with missing values. +### Enhancements + +- Increased the default linespacing used by themes from `0.9` to `1.2`. + This gives multiline titles, subtitles and captions a better balance between looking compact and looking crumpled. + ## v0.15.3 (2025-01-28) diff --git a/plotnine/themes/theme_gray.py b/plotnine/themes/theme_gray.py index db149eec6e..a048aa7779 100644 --- a/plotnine/themes/theme_gray.py +++ b/plotnine/themes/theme_gray.py @@ -47,7 +47,7 @@ def __init__(self, base_size=11, base_family=None): color="black", ma="center", size=base_size, - linespacing=0.9, + linespacing=1.2, rotation=0, margin=margin(), ), diff --git a/plotnine/themes/theme_void.py b/plotnine/themes/theme_void.py index d1c4d3bd0b..8f72ffd22a 100644 --- a/plotnine/themes/theme_void.py +++ b/plotnine/themes/theme_void.py @@ -36,7 +36,7 @@ def __init__(self, base_size=11, base_family=None): style="normal", color="black", size=base_size, - linespacing=0.9, + linespacing=1.2, rotation=0, margin=margin(), ), diff --git a/tests/baseline_images/test_layout/axis_text_justification.png b/tests/baseline_images/test_layout/axis_text_justification.png index d7445551ce..bd19ef81d3 100644 Binary files a/tests/baseline_images/test_layout/axis_text_justification.png and b/tests/baseline_images/test_layout/axis_text_justification.png differ diff --git a/tests/baseline_images/test_layout/axis_title_x_justification.png b/tests/baseline_images/test_layout/axis_title_x_justification.png index 9f26c42f6f..9bfefbf82c 100644 Binary files a/tests/baseline_images/test_layout/axis_title_x_justification.png and b/tests/baseline_images/test_layout/axis_title_x_justification.png differ diff --git a/tests/baseline_images/test_layout/axis_title_y_justification.png b/tests/baseline_images/test_layout/axis_title_y_justification.png index 3d0cca7192..64887c362a 100644 Binary files a/tests/baseline_images/test_layout/axis_title_y_justification.png and b/tests/baseline_images/test_layout/axis_title_y_justification.png differ diff --git a/tests/baseline_images/test_layout/colorbar_frame.png b/tests/baseline_images/test_layout/colorbar_frame.png index e576a7ac76..6a5b70cbd4 100644 Binary files a/tests/baseline_images/test_layout/colorbar_frame.png and b/tests/baseline_images/test_layout/colorbar_frame.png differ diff --git a/tests/baseline_images/test_layout/default.png b/tests/baseline_images/test_layout/default.png index 59edd6be3a..a4906cfb93 100644 Binary files a/tests/baseline_images/test_layout/default.png and b/tests/baseline_images/test_layout/default.png differ diff --git a/tests/baseline_images/test_layout/different_colorbar_themes.png b/tests/baseline_images/test_layout/different_colorbar_themes.png index 035fe2a63c..bab4b0beb9 100644 Binary files a/tests/baseline_images/test_layout/different_colorbar_themes.png and b/tests/baseline_images/test_layout/different_colorbar_themes.png differ diff --git a/tests/baseline_images/test_layout/facet_grid.png b/tests/baseline_images/test_layout/facet_grid.png index bab6cb2cce..471d4740e5 100644 Binary files a/tests/baseline_images/test_layout/facet_grid.png and b/tests/baseline_images/test_layout/facet_grid.png differ diff --git a/tests/baseline_images/test_layout/facet_wrap.png b/tests/baseline_images/test_layout/facet_wrap.png index b7fa75b77d..7995b3e0bd 100644 Binary files a/tests/baseline_images/test_layout/facet_wrap.png and b/tests/baseline_images/test_layout/facet_wrap.png differ diff --git a/tests/baseline_images/test_layout/facet_wrap_scales_free.png b/tests/baseline_images/test_layout/facet_wrap_scales_free.png index 5b161a6fe5..078d057248 100644 Binary files a/tests/baseline_images/test_layout/facet_wrap_scales_free.png and b/tests/baseline_images/test_layout/facet_wrap_scales_free.png differ diff --git a/tests/baseline_images/test_layout/legend_at_the_bottom.png b/tests/baseline_images/test_layout/legend_at_the_bottom.png index 1c40e1235f..9e4adf5223 100644 Binary files a/tests/baseline_images/test_layout/legend_at_the_bottom.png and b/tests/baseline_images/test_layout/legend_at_the_bottom.png differ diff --git a/tests/baseline_images/test_layout/legend_at_top.png b/tests/baseline_images/test_layout/legend_at_top.png index fefea63343..e174d3f0e8 100644 Binary files a/tests/baseline_images/test_layout/legend_at_top.png and b/tests/baseline_images/test_layout/legend_at_top.png differ diff --git a/tests/baseline_images/test_layout/legend_on_the_left.png b/tests/baseline_images/test_layout/legend_on_the_left.png index 8e51b4e81d..e954d8ad6a 100644 Binary files a/tests/baseline_images/test_layout/legend_on_the_left.png and b/tests/baseline_images/test_layout/legend_on_the_left.png differ diff --git a/tests/baseline_images/test_layout/legends_in_different_positions.png b/tests/baseline_images/test_layout/legends_in_different_positions.png index 74e0581be9..fe0e2d3c07 100644 Binary files a/tests/baseline_images/test_layout/legends_in_different_positions.png and b/tests/baseline_images/test_layout/legends_in_different_positions.png differ diff --git a/tests/baseline_images/test_layout/plot_footer.png b/tests/baseline_images/test_layout/plot_footer.png index 10c668ffbc..9509ebde8a 100644 Binary files a/tests/baseline_images/test_layout/plot_footer.png and b/tests/baseline_images/test_layout/plot_footer.png differ diff --git a/tests/baseline_images/test_layout/plot_footer_background.png b/tests/baseline_images/test_layout/plot_footer_background.png index 6d26267111..4a9f5a91ea 100644 Binary files a/tests/baseline_images/test_layout/plot_footer_background.png and b/tests/baseline_images/test_layout/plot_footer_background.png differ diff --git a/tests/baseline_images/test_layout/plot_title_justification.png b/tests/baseline_images/test_layout/plot_title_justification.png index 9901b00185..3226b88c6b 100644 Binary files a/tests/baseline_images/test_layout/plot_title_justification.png and b/tests/baseline_images/test_layout/plot_title_justification.png differ diff --git a/tests/baseline_images/test_layout/plot_titles_and_caption_positioning.png b/tests/baseline_images/test_layout/plot_titles_and_caption_positioning.png index a15c95f0cf..21ff177ce7 100644 Binary files a/tests/baseline_images/test_layout/plot_titles_and_caption_positioning.png and b/tests/baseline_images/test_layout/plot_titles_and_caption_positioning.png differ diff --git a/tests/baseline_images/test_layout/turn_off_guide.png b/tests/baseline_images/test_layout/turn_off_guide.png index 87b216c37b..ab81c994a4 100644 Binary files a/tests/baseline_images/test_layout/turn_off_guide.png and b/tests/baseline_images/test_layout/turn_off_guide.png differ diff --git a/tests/baseline_images/test_plot_composition/horizontal_tag_align.png b/tests/baseline_images/test_plot_composition/horizontal_tag_align.png index e89ac73861..89096da494 100644 Binary files a/tests/baseline_images/test_plot_composition/horizontal_tag_align.png and b/tests/baseline_images/test_plot_composition/horizontal_tag_align.png differ diff --git a/tests/baseline_images/test_scale_labelling/caption_complex.png b/tests/baseline_images/test_scale_labelling/caption_complex.png index bc6f48e9ff..cafc94d63b 100644 Binary files a/tests/baseline_images/test_scale_labelling/caption_complex.png and b/tests/baseline_images/test_scale_labelling/caption_complex.png differ