Merge pull request #1178 from johndoknjas/set-hash-after-threads

Ensure hash is always set after threads.

Author: niklasf

chess/engine.py

@@ -1875,12 +1875,16 @@ def _parse_uci_bestmove(board: chess.Board, args: str) -> BestMove:
     return BestMove(move, ponder)
 
 
-def _chain_config(a: ConfigMapping, b: ConfigMapping) -> Iterator[Tuple[str, ConfigValue]]:
-    for name, value in a.items():
-        yield name, value
-    for name, value in b.items():
-        if name not in a:
-            yield name, value
+def _chain_config(a: ConfigMapping, b: ConfigMapping) -> Iterable[Tuple[str, ConfigValue]]:
+    merged = dict(a)
+    for k, v in b.items():
+        merged.setdefault(k, v)
+    if "Hash" in merged and "Threads" in merged:
+        # Move Hash after Threads, as recommended by Stockfish.
+        hash_val = merged["Hash"]
+        del merged["Hash"]
+        merged["Hash"] = hash_val
+    return merged.items()
 
 
 class UciOptionMap(MutableMapping[str, T]):