fix: cache get heroes lookup to make much more performant

Author: Js41637

DataTool/DataModels/Hero/Talent.cs

@@ -55,7 +55,7 @@ public void Init(STUTalentBase stu, ulong key = default) {
 
                 Loadout = new HeroLoadout {
                     GUID = talent.m_loadout,
-                    Name = LoadoutVM.GetName(talent.m_loadout),
+                    Name = Helpers.GetLoadoutById(talent.m_loadout)?.Name,
                     HeroGUID = hero?.GUID ?? null,
                     HeroName = hero?.Name,
                 };
@@ -67,13 +67,13 @@ public void Init(STUTalentBase stu, ulong key = default) {
 
                 Loadout = new HeroLoadout {
                     GUID = perk.m_loadout,
-                    Name = LoadoutVM.GetName(perk.m_loadout),
+                    Name = Helpers.GetLoadoutById(perk.m_loadout)?.Name,
                     HeroGUID = hero?.GUID ?? null,
                     HeroName = hero?.Name,
                 };
             }
 
-            Name = LoadoutVM.GetName(perk.m_loadout);
+            Name = Helpers.GetLoadoutById(perk.m_loadout)?.Name;
             Level = (int) perk.m_4DDE5023;
             Major = perk.m_D60C9EA2 != 0;
         }

DataTool/Helper/Helpers.cs

@@ -4,25 +4,63 @@
 using System.Linq;
 using DataTool.DataModels.Hero;
 using TankLib;
-using TankLib.STU.Types;
 
 namespace DataTool.Helper;
 
 public static class Helpers {
+    private static Dictionary<teResourceGUID, HeroVM>? _heroesCache;
+    private static Dictionary<teResourceGUID, LoadoutVM>? _loadoutsCache;
+
     /// <summary>
-    /// Returns dictionary of all Heroes by GUID using the <see cref="Hero"/> data model.
+    /// Returns dictionary of all Heroes by GUID using the <see cref="HeroVM"/> data model.
     /// </summary>
     public static Dictionary<teResourceGUID, Hero> GetHeroes() {
+        if (_heroesCache != null) {
+            return _heroesCache;
+        }
+
         var @return = new Dictionary<teResourceGUID, Hero>();
         foreach (teResourceGUID key in Program.TrackedFiles[0x75]) {
-            var hero = STUHelper.GetInstance<STUHero>(key);
+            var hero = HeroVM.Load(key);
             if (hero == null) continue;
-            @return[key] = new Hero(hero, key);
+            @return[key] = hero;
         }
 
+        _heroesCache = @return;
         return @return;
     }
 
+    /// <summary>
+    /// Returns dictionary of all Loadouts by GUID using the <see cref="LoadoutVM"/> data model.
+    /// </summary>
+    public static Dictionary<teResourceGUID, Loadout> GetLoadouts() {
+        if (_loadoutsCache != null) {
+            return _loadoutsCache;
+        }
+
+        var @return = new Dictionary<teResourceGUID, Loadout>();
+        foreach (teResourceGUID key in Program.TrackedFiles[0x9E]) {
+            var loadout = LoadoutVM.Load(key);
+            if (loadout == null) continue;
+            @return[key] = loadout;
+        }
+
+        _loadoutsCache = @return;
+        return @return;
+    }
+
+    /// <summary>Returns a Loadout by its GUID</summary>
+    public static LoadoutVM? GetLoadoutById(ulong guid) {
+        var loadouts = GetLoadouts();
+        return loadouts.GetValueOrDefault((teResourceGUID) guid);
+    }
+
+    /// <summary>Returns a Hero by its GUID</summary>
+    public static HeroVM? GetHeroById(ulong guid) {
+        var heroes = GetHeroes();
+        return heroes.GetValueOrDefault((teResourceGUID) guid);
+    }
+
     /// <summary>
     /// Returns a mapping of hero names to their GUIDs in lowercase.
     /// </summary>
@@ -42,7 +80,7 @@ public static IgnoreCaseDict<string> GetHeroNameLocaleOverrides(Dictionary<teRes
             if (!namesForThisLocale.TryGetValue(localizedName.Value, out var nameForThisLocale)) {
                 continue;
             }
-            
+
             if (localizedName.Key.Equals(nameForThisLocale, StringComparison.OrdinalIgnoreCase)) {
                 // identical, don't bother mapping
                 continue;