Skip to content

Commit 7f19235

Browse files
authored
Remove flake8-mypy in favor of direct mypy usage (#2248)
1 parent 56c9fc7 commit 7f19235

File tree

6 files changed

+43
-67
lines changed

6 files changed

+43
-67
lines changed

.arclint

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,15 @@
118118
"(\\.pxl$)"
119119
]
120120
},
121+
"mypy": {
122+
"type": "script-and-regex",
123+
"include": [
124+
"(\\.py$)",
125+
"(\\.pxl$)"
126+
],
127+
"script-and-regex.script": "mypy --config-file=mypy.ini",
128+
"script-and-regex.regex": "/^(?P<file>.*):(?P<line>\\d+): (?P<severity>error|warning): (?P<message>.*)$/m"
129+
},
121130
"gazelle": {
122131
"type": "script-and-regex",
123132
"include": [

.flake8rc

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,34 +4,3 @@ max-line-length = 120
44
# N802: Function names have to be lower case. This is for GRPC service.
55
# E999: Mistaken error see https://github.com/PyCQA/pycodestyle/issues/584
66
ignore = N802,E999,W503
7-
8-
[mypy]
9-
python_version=3.6
10-
11-
show_column_numbers=True
12-
show_error_context=False
13-
14-
# suppress errors about unsatisfied imports
15-
ignore_missing_imports=True
16-
17-
# allow untyped calls as a consequence of the options above
18-
disallow_untyped_calls=False
19-
20-
# allow returning Any as a consequence of the options above
21-
warn_return_any=False
22-
23-
# treat Optional per PEP 484
24-
strict_optional=True
25-
26-
# ensure all execution paths are returning
27-
warn_no_return=True
28-
29-
# lint-style cleanliness for typing needs to be disabled; returns more errors
30-
# than the full run.
31-
warn_redundant_casts=False
32-
warn_unused_ignores=False
33-
34-
# The following are off by default since they're too noisy.
35-
# Flip them on if you feel adventurous.
36-
disallow_untyped_defs=False
37-
check_untyped_defs=False

.pxl.flake8rc

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,3 @@ max-line-length = 120
55
# E999: Mistaken error see https://github.com/PyCQA/pycodestyle/issues/584
66
# F821: Undefined name 'px'. We should fix this in pxl lang.
77
ignore = N802,E999,F821,W503
8-
9-
[mypy]
10-
python_version=3.6
11-
12-
show_column_numbers=True
13-
show_error_context=False
14-
15-
# suppress errors about unsatisfied imports
16-
ignore_missing_imports=True
17-
18-
# allow untyped calls as a consequence of the options above
19-
disallow_untyped_calls=False
20-
21-
# allow returning Any as a consequence of the options above
22-
warn_return_any=False
23-
24-
# treat Optional per PEP 484
25-
strict_optional=True
26-
27-
# ensure all execution paths are returning
28-
warn_no_return=True
29-
30-
# lint-style cleanliness for typing needs to be disabled; returns more errors
31-
# than the full run.
32-
warn_redundant_casts=False
33-
warn_unused_ignores=False
34-
35-
# The following are off by default since they're too noisy.
36-
# Flip them on if you feel adventurous.
37-
disallow_untyped_defs=False
38-
check_untyped_defs=False

docker.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
DOCKER_IMAGE_TAG=202506270326
2-
LINTER_IMAGE_DIGEST=05aeeb210dec4b5753e55376aef7df013bb136a3ad70524fa1dff24f832b5c4e
3-
DEV_IMAGE_DIGEST=f0a0c803733d6ad8c9104f745378ab9d7a95263a3f8882fc28f11c79c1200d1f
4-
DEV_IMAGE_WITH_EXTRAS_DIGEST=17c8ce9c4bd4dba40cdd6e40bdee726237336dbd6581deca864ebe9302cff569
1+
DOCKER_IMAGE_TAG=202507242250
2+
LINTER_IMAGE_DIGEST=911f172364626f44efb61345517b5e7bb8c8ee8f065fcf3ba0a790ab1a88cdcb
3+
DEV_IMAGE_DIGEST=08fc759c2b45078214be313335b8c3c23200aea54b9609e8c42fe367762e6c7c
4+
DEV_IMAGE_WITH_EXTRAS_DIGEST=0ecefa696cfad238c432c2e213600263d00dda4ca4a427796f8fc16eb3d9bfc0

mypy.ini

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
[mypy]
2+
python_version = 3.8
3+
show_column_numbers = True
4+
show_error_context = False
5+
6+
# suppress errors about unsatisfied imports
7+
ignore_missing_imports = True
8+
9+
# allow untyped calls as a consequence of the options above
10+
disallow_untyped_calls = False
11+
12+
# allow returning Any as a consequence of the options above
13+
warn_return_any = False
14+
15+
# treat Optional per PEP 484
16+
strict_optional = True
17+
18+
# ensure all execution paths are returning
19+
warn_no_return = True
20+
21+
# lint-style cleanliness for typing needs to be disabled; returns more errors
22+
# than the full run.
23+
warn_redundant_casts = False
24+
warn_unused_ignores = False
25+
26+
# The following are off by default since they're too noisy.
27+
# Flip them on if you feel adventurous.
28+
disallow_untyped_defs = False
29+
check_untyped_defs = False

tools/chef/cookbooks/px_dev/recipes/linters.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
end
2727

2828
execute 'install py linters' do
29-
command 'python3 -m pip install --break-system-packages flake8 flake8-mypy yamllint --no-cache-dir && python3 -m pip cache purge'
29+
command 'python3 -m pip install --break-system-packages flake8 mypy yamllint --no-cache-dir && python3 -m pip cache purge'
3030
end
3131

3232
common_remote_bin 'prototool'

0 commit comments

Comments
 (0)