From b96375659d151fbd7e07276f1802c0fbc97d3698 Mon Sep 17 00:00:00 2001 From: Corentin <4438248+CorentinS6@users.noreply.github.com> Date: Tue, 21 Oct 2025 12:05:14 +0200 Subject: [PATCH 1/3] prevent non existing key "bypass_filter_assign_group" in ticket.class.php fix PHP Warning (2): Undefined array key "bypass_filter_assign_group" in /var/www/glpi/plugins/escalade/inc/ticket.class.php at line 1270 --- inc/ticket.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/ticket.class.php b/inc/ticket.class.php index 5e58bad..357b7e9 100644 --- a/inc/ticket.class.php +++ b/inc/ticket.class.php @@ -1264,7 +1264,7 @@ public function showForm($ID, $options = []) $condition = [ 'is_assign' => 1, ]; - if ($config->fields['use_filter_assign_group'] && !$user_config->fields['bypass_filter_assign_group']) { + if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) { $condition['id'] = $groups_id_filtered; } TemplateRenderer::getInstance()->display('@escalade/escalade_form.html.twig', [ From 8f9b665c619670138b77ebc99847bfefaa7d26ba Mon Sep 17 00:00:00 2001 From: Corentin <4438248+CorentinS6@users.noreply.github.com> Date: Tue, 27 Jan 2026 12:55:24 +0100 Subject: [PATCH 2/3] Update inc/ticket.class.php Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> --- inc/ticket.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/ticket.class.php b/inc/ticket.class.php index 357b7e9..fb87509 100644 --- a/inc/ticket.class.php +++ b/inc/ticket.class.php @@ -1264,7 +1264,7 @@ public function showForm($ID, $options = []) $condition = [ 'is_assign' => 1, ]; - if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) { + if ($config->fields['use_filter_assign_group'] ?? false && !($user_config->fields['bypass_filter_assign_group'] ?? false)) { $condition['id'] = $groups_id_filtered; } TemplateRenderer::getInstance()->display('@escalade/escalade_form.html.twig', [ From 15c1cbdd792614bd0c251a4b0dffd8df57273272 Mon Sep 17 00:00:00 2001 From: Corentin <4438248+CorentinS6@users.noreply.github.com> Date: Wed, 28 Jan 2026 10:46:50 +0100 Subject: [PATCH 3/3] fix ci --- inc/ticket.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/ticket.class.php b/inc/ticket.class.php index fb87509..bd5b01c 100644 --- a/inc/ticket.class.php +++ b/inc/ticket.class.php @@ -1264,7 +1264,7 @@ public function showForm($ID, $options = []) $condition = [ 'is_assign' => 1, ]; - if ($config->fields['use_filter_assign_group'] ?? false && !($user_config->fields['bypass_filter_assign_group'] ?? false)) { + if (($config->fields['use_filter_assign_group'] ?? false) && !($user_config->fields['bypass_filter_assign_group'] ?? false)) { $condition['id'] = $groups_id_filtered; } TemplateRenderer::getInstance()->display('@escalade/escalade_form.html.twig', [