Skip to content

Fix ITILSolution given error #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lainow wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix ITILSolution given error #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@
}
}

public static function requireFieldsToClose(CommonITILObject $item): void
public static function requireFieldsToClose($item): void

Check failure on line 327 in src/Controller.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.5 - mariadb:11.8 / Continuous integration 

Method GlpiPlugin\Moreoptions\Controller::requireFieldsToClose() has parameter $item with no type specified.

Check failure on line 327 in src/Controller.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.2 - mariadb:10.6 / Continuous integration 

Method GlpiPlugin\Moreoptions\Controller::requireFieldsToClose() has parameter $item with no type specified.
{
$conf = Config::getConfig();
if ($conf->fields['is_active'] != 1) {
Expand All @@ -335,7 +335,7 @@
$itemtype = get_class($item);

// Determine the configuration suffix and actor classes based on item type
$configSuffix = '_' . strtolower($itemtype);

Check failure on line 338 in src/Controller.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.5 - mariadb:11.8 / Continuous integration 

Parameter #1 $string of function strtolower expects string, class-string|false given.

Check failure on line 338 in src/Controller.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.2 - mariadb:10.6 / Continuous integration 

Parameter #1 $string of function strtolower expects string, class-string|false given.
$userClass = $item->userlinkclass;
$groupClass = $item->grouplinkclass;
$itemIdField = $item->getForeignKeyField();
Expand Down Expand Up @@ -396,7 +396,7 @@
$solution = new ITILSolution();
$solutions = $solution->find([
'itemtype' => $itemtype,
'items_id' => $item->fields['id'],

Check failure on line 399 in src/Controller.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.5 - mariadb:11.8 / Continuous integration 

Access to an undefined property object::$fields.

Check failure on line 399 in src/Controller.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.2 - mariadb:10.6 / Continuous integration 

Access to an undefined property object::$fields.
'NOT' => [
'status' => CommonITILValidation::REFUSED,
],
Expand Down
Loading