rename response_length to response_size#14
Open
rghvdberg wants to merge 1 commit intoAbuseIO:masterfrom
Open
Conversation
Member
|
rejected change although it makes sense now, the field was other in the past. IF you ever want to add old reports back it would fail. This is why we have ALIAS method inside the definition. Have a look at the botnet_drone currently configured. This way both old and new will still work. Please update your PR to be accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs https://www.shadowserver.org/what-we-do/network-reporting/open-ms-sql-server-resolution-service-report/ state
that there's a field called
response_length, however in de sample at the bottom of the page and in the csv report we received the field is namedresponse_size.