Integrate TRD extra data support in AOD production workflow#14734
Open
KangkanGoswami wants to merge 4 commits intoAliceO2Group:devfrom
Open
Integrate TRD extra data support in AOD production workflow#14734KangkanGoswami wants to merge 4 commits intoAliceO2Group:devfrom
KangkanGoswami wants to merge 4 commits intoAliceO2Group:devfrom
Conversation
This commit enables the workflow to process TRD-specific calibration and noise information, allowing for more accurate reconstruction and analysis of TRD signals in AOD production.
This commit enables the workflow to generate TRD-specific extra tables in the AOD, applying calibration and noise corrections to improve reconstruction fidelity for TRD tracks.
This change allows users to enable or disable TRD extra output at runtime via workflow configuration, integrating TRD processing into the AOD production workflow.
…isDataModel.h This update to AnalysisDataModel.h standardizes TRD-related naming and introduces a dedicated SOA table for TRD extra data, allowing calibrated and corrected TRD quantities to be stored within the AOD framework.
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
approved these changes
Oct 20, 2025
Collaborator
sawenzel
left a comment
sawenzel
left a comment
There was a problem hiding this comment.
tmp approving to trigger CI
sawenzel
reviewed
Oct 20, 2025
Collaborator
sawenzel
left a comment
sawenzel
left a comment
There was a problem hiding this comment.
As previously commented, this should be discussed with the analysis work-package (WP4).
Collaborator
|
Error while checking build/O2/fullCI_slc9 for c1dce5b at 2026-02-05 11:55: Full log here. |
Author
Sure, I will present a detailed motivation and computation cost of these additions in the upcoming meeting. |
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
Author
As per our discussion in the WP4 meeting (https://indico.cern.ch/event/1532956/), we made some estimations regarding how much time this PR should take. I did it using the "time" command, it take around 1m26.930s (for a processor Intel i7-10700 (16) @ 4.800GHz ). This is for 10TFs. Kindly let me know if I need to do something before going ahead with the merging. |
Member
|
What is the baseline? |
Author
With --enable-TRD-extra it is taking 1m26.930s, without --enable-TRD-extra, it is taking around 1m24.536s. |
Collaborator
|
From my side it's fine to be merged. |
Collaborator
|
@jackal1-66 : Could you please take a short look why the full-system-test is now failing? |
Collaborator
|
The AO2D.root file is effectively not produced. I checked in the CI machine and the file is not there. From the reco_ASYNC.log I see: So the output is dropped and not written in the AO2D. The TRD info seems to be missing from the LOG, could you check if it's properly pushed to the output? |
Member
|
Something in #15005 silently broke things. Reverted and rebuild ongoing. |
Collaborator
|
The AO2D is still not produced, so something else must be wrong in this PR. Can you please check @KangkanGoswami ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds TRD extra data support to the AOD production workflow, including calibrated tracklet handling, local gain and noise corrections, and a new TRDsExtra SOA table in AnalysisDataModel.h. The changes introduce an optional runtime flag (--enable-TRD-extra) to control TRD output and extend existing workflow templates and data structures to incorporate TRD-specific quantities for improved reconstruction and analysis.