Skip to content

Conversation

@louisemillot
Copy link

Add detailed jet substructure analysis for data, MCD, and MCP

  • Implemented soft-drop jet reclustering with constituent handling
  • Filled matched histograms for geometry- and event-wise matched jets
  • Added event selection and centrality cuts for collisions in data and MC
  • Handled weighted MC events and event-wise constituent-subtracted jets
  • Updated histograms for leading/subleading prongs, zg, rg, and thetag observables
  • Added QA histograms for collisions and pTHat checks

@github-actions github-actions bot changed the title Jet substructure SoftDrop [PWGJE] Jet substructure SoftDrop Feb 11, 2026
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{adaptAnalysisTask<JetSubstructureSoftDrop>(
cfgc, TaskName{"jet-substructure-softdrop"})}; // o2-linter: disable=name/o2-task(Required for correct DPL workflow)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "Required for correct DPL workflow"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had initially tried without explicitly setting the TaskName, but in that case the workflow was not starting correctly in my DPL test setup. Forcing the TaskName made the device appear and run as expected. That’s why I added the override and the linter disable. I also followed the documentation, which suggested suppressing the linter in this case

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your task name JetSubstructureSoftDrop should generate a device name jet-substructure-soft-drop. Did you observe anything else?

Copy link
Author

@louisemillot louisemillot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I remove the explicit TaskName and rely only on adaptAnalysisTask<JetSubstructureSoftDrop>(cfgc), the device is built but in my DPL test workflow it does not run correctly and no histograms are produced.
With the explicit TaskName{"jet-substructure-softdrop"}, the device appears in the workflow graph and the histograms are filled as expected.
That’s why I kept the explicit TaskName and temporarily disabled the linter rule.

Copy link
Collaborator

@vkucera vkucera Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means that you have wrong names in your test workflow. You need to fix your test, not change the device name.
Which workflow graph are you talking about?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im using this workflow o2-analysis-je-jet-substructure-softdrop when removing the TaskName

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the O2Framework debug GUI workflow graph. I was using it to check whether the device appears and runs, but I’ve currently disabled it and relied on the log output instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants