[OGUI-1788] Implementation of crucial services used to communicate with Vault REST API#3195
Open
[OGUI-1788] Implementation of crucial services used to communicate with Vault REST API#3195
Conversation
…ub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1715/central-system-structure
…points naming and dev vault permisions
…ceO2Group/WebUi into feature/TKN/OGUI-1788/vault-services
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| const logger = LogManager.getLogger('Database'); |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 months ago
The best way to fix the unused variable logger is to remove its declaration entirely from the code snippet. This is a single-line removal on line 37 of the file Tokenization/backend/central-system/src/lib/database/Database.ts. No other code modifications are required, as there is no evidence that logger is needed for any other logic within the snippet.
Suggested changeset
1
Tokenization/backend/central-system/src/lib/database/Database.ts
| @@ -34,7 +34,6 @@ | ||
| } | ||
| } | ||
|
|
||
| const logger = LogManager.getLogger('Database'); | ||
|
|
||
| export const db = await Database.createDatabase({ | ||
| host: process.env.DB_HOST ?? 'database', |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Implementation of services that use the Vault REST API for logging the Central System into Vault as a client to obtain an access token for subsequent calls, renewing that token, signing data using the Transit engine, and creating, updating, or retrieving credentials/secrets from Vault.