Conversation
There was a problem hiding this comment.
Pull request overview
Updates environment event handling to rely on ECS-provided transition status values, removing brittle hardcoded message-string comparisons.
Changes:
- Switch cache update/removal logic from
messagestring checks totransition.status === DONE_OK. - Extend
EcsOperationAndStepStatusenum with additional ECS statuses (NULL/STARTED/ONGOING). - Update and add unit tests to validate DESTROY removal and clearing
isDeployingafter successful configure completion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Control/lib/services/environment/EnvironmentCache.service.js | Uses ECS transition status (DONE_OK) for deploy completion and successful destroy removal logic. |
| Control/lib/common/ecsOperationAndStepStatus.enum.js | Adds missing ECS operation/step statuses and links to proto definition. |
| Control/test/lib/services/environment/mocha-environment-cache.service.test.js | Updates existing test to use transition.status and adds coverage for clearing isDeploying on successful configure completion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Control/test/lib/services/environment/mocha-environment-cache.service.test.js
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
PR which:
EcsOperationAndStepStatusenum with additional ECS statuses (NULL/STARTED/ONGOING).