chore(bootstrap): default NUM_TXES to 8 for test harness#33
Open
getsmatu wants to merge 1 commit intoAztecProtocol:masterfrom
Open
chore(bootstrap): default NUM_TXES to 8 for test harness#33getsmatu wants to merge 1 commit intoAztecProtocol:masterfrom
getsmatu wants to merge 1 commit intoAztecProtocol:masterfrom
Conversation
The test harness assumes 8 txe instances are running, but NUM_TXES defaulted to 1 when unset, causing all tests to reuse the same port 45730. This change updates the default to 8 so that tests distribute across eight ports by default, matching the comment and enabling proper parallelism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test harness assumes 8 txe instances are running, but NUM_TXES defaulted to 1 when unset, causing all tests to reuse the same port 45730. This change updates the default to 8 so that tests distribute across eight ports by default, matching the comment and enabling proper parallelism.