This repository was archived by the owner on Jan 19, 2024. It is now read-only.
Replace TrimBeginningAndEndingSlashes with str.strip#140
Open
nuno-andre wants to merge 2 commits intoAzure:masterfrom
Open
Replace TrimBeginningAndEndingSlashes with str.strip#140nuno-andre wants to merge 2 commits intoAzure:masterfrom
nuno-andre wants to merge 2 commits intoAzure:masterfrom
Conversation
|
|
|
Manually started CI on this PR: https://cosmos-db-sdk-public.visualstudio.com/cosmos-db-sdk-public/_build/results?buildId=1279 |
christopheranderson
requested review from
christopheranderson and
srinathnarayanan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
strbuilt-in type has a method just for the same kind of munging asTrimBeginningAndEndingSlashes:str.strip('/'). It also has methods for removing leading (lstrip) or ending (rstrip) characters.Furthermore, it's a more performant and idiomatic approach than the current one.