feat: share speach profile #4650
Draft
+515
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it for shared profiles Previously shared profiles loaded the sharer's contacts instead of their own voice. Now we extract and store an embedding when a user uploads their speech profile, and load that embedding during transcription for shared profile speaker identification. Also removes the broken persistent speaker_id mapping that incorrectly cached session-local IDs across sessions.
- Merge speech_profile_sharing.dart into speech_profile.dart - Add Pydantic model for share/revoke request body - Validate target user exists before sharing - Remove dead get_user_speaker_embedding function - Use single Firestore read per shared owner in transcription - Add l10n keys for sharing UI strings - Add Logger.debug to Dart API functions - Fix indentation and EOF newlines
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature for sharing speech profiles between users. It adds the necessary backend API endpoints for sharing, revoking, and listing shared profiles, along with corresponding UI elements in the mobile app. The backend is also updated to extract and utilize speaker embeddings from both user-owned and shared profiles for improved speaker identification. The implementation is solid, but the identified high-severity issues related to database query efficiency and error handling still need to be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3040
Description
Adds support for sharing speech profiles between users