feat(app): automated Maestro E2E functional tests (#3857) #4733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configures Maestro for automated functional testing with core flows and device-required flow separation via tags.
Tests app launch, sign-in, name entry, language selection, permissions, speech profile skip, and home screen landing.
Tests conversation list rendering, scrolling, and list item visibility.
Tests opening a conversation, viewing transcript, and detail screen elements.
Tests creating, updating, and deleting conversations through the UI.
Tests memory list display, creation, and interaction.
Tests chat input, message sending, and AI response display.
Tests app store browsing, plugin installation, and management.
Tests settings screen navigation, preference toggles, and profile access.
Tests BLE device scanning, pairing, and connection status. Requires physical Omi device (tagged device_required).
Tests recording start, transcription indicator, and conversation creation from captured audio. Requires physical Omi device.
Runs all core E2E flows sequentially with pass/fail summary and optional HTML report generation.
Runs Maestro flows that require a physical Omi device connected.
Adds --e2e flag to run Maestro functional tests alongside existing unit/widget tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of Maestro E2E tests, which is a great addition for ensuring app quality. The tests cover core functionality and are well-structured with tags for simulator vs. device-specific flows. My review focuses on improving the maintainability and robustness of the new test scripts. I've identified a few areas with code duplication in both the YAML flow definitions and the shell runner scripts. Addressing these will make the test suite more resilient and easier to manage as the app evolves.
…g flow Merges duplicate Maybe Later/later runFlow blocks into a single regex-based match per code review feedback.
…_all.sh Uses --exclude-tags=device_required to run all core flows dynamically, keeping config.yaml as the single source of truth for flow categorization.
…_device.sh Uses --include-tags=device_required to run device flows dynamically, keeping config.yaml as the single source of truth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
core(runs on simulator) vsdevice_required(needs physical Omi hardware)run_all.sh,run_device.sh) with pass/fail reporting and optional HTML outputtest.shvia--e2eflagHow It Works
brew install maestrobash app/.maestro/scripts/run_all.shbash app/.maestro/scripts/run_device.shbash app/test.sh --e2eto run unit + widget + E2E tests togetherAfter ~1 hour you get a full report covering sign-in, conversation recording/transcription, CRUD operations, chat, and app management.
Test Flows
Test plan
flutter build ios --flavor dev --simulatorbash app/.maestro/scripts/run_all.shon simulatorbash app/.maestro/scripts/run_device.shwith Omi connectedCloses #3857