fix(build): Support FFMPEG_INCLUDE_DIR on Linux for hardsubx #1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation with hardsubx on Linux systems where FFmpeg headers are installed in non-standard locations (e.g.,
/usr/include/ffmpegon Fedora with rpmfusion).The Problem
The
FFMPEG_INCLUDE_DIRenvironment variable was only checked inside the macOS-specific block inbuild.rs, so setting it had no effect on Linux builds:The Fix
FFMPEG_INCLUDE_DIRcheck outside platform-specific blocks - Now works on all platformsUsage
Users can now build on Fedora/systems with non-standard FFmpeg paths:
Or rely on pkg-config if FFmpeg is properly configured.
Fixes #1954
🤖 Generated with Claude Code