feat(AddTaskDialog): add DateTimePicker for entry field #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace DatePicker with DateTimePicker for start field in AddTaskDialog - Add DateTimePicker mock in AddTaskDialog.test.tsx - Add comprehensive tests for DateTime fields (render, update, clear, submit) - Support both date-only and datetime formats Contributes: CCExtractor#325
- Replace DatePicker with DateTimePicker for entry field in AddTaskDialog - Add entry to dateTimeFields array in tests - Support both date-only and datetime formats for entry Contributes: CCExtractor#325
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace DatePicker with DateTimePicker for entry field in AddTaskDialog
Add entry to dateTimeFields array in tests
Support both date-only and datetime formats for entry
Contributes: Add additional time picker for time(and date) based fields in AddTaskDialog #325
Stacked PR -> please merge after PR #376
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Screenshots: