Skip to content

Conversation

@Ni1esh-Yadav
Copy link
Contributor

Description:

This PR resolves the issue where the modal did not close after clicking the "Yes" button. The button is now wrapped inside <DialogClose>, ensuring that the modal closes automatically upon clicking "Yes."

Fixes:

  • Wrapped the "Yes" button inside <DialogClose>, allowing automatic modal closure.
  • Ensured a smooth user experience without additional actions needed to close the modal.

Changes Made:

  • Updated modal component to use <DialogClose> around the "Yes" button.
  • Tested and confirmed that the modal now closes immediately when "Yes" is clicked.

closes #81

Testing:

  • Manually tested on different browsers/devices
  • Verified no console errors on modal close
  • Checked expected behavior across different interactions

Impact & Rollback Plan:

  • No breaking changes expected.
  • If issues arise, we can revert the <DialogClose> wrapper and re-evaluate the approach.

@its-me-abhishek its-me-abhishek merged commit c902623 into CCExtractor:main Mar 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The modal does not close automatically as expected

2 participants