Skip to content

Conversation

@namm2
Copy link

@namm2 namm2 commented Dec 29, 2025

Use secretKeyRef to not expose Clickhouse credentials into runtime environment

Signed-off-by: Nam Hai Nguyen <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Nam Hai Nguyen <[email protected]>
@HamseTelia
Copy link

Could we also please add the clickhouse user's password to be referenced from a secret clickhouse.config.users.appUserPassword. Like suggested here: #125

clickhouse:
  config:
    users:
      # Existing inline password support (for backward compatibility)
      appUserPassword: "hyperdx"
      otelUserPassword: "otelcollectorpass"
      otelUserName: "otelcollector"
      
      # NEW: External secret support
      useExternalSecret: false
      externalSecret:
        name: ""
        appUserPasswordKey: "app-user-password"

@namm2
Copy link
Author

namm2 commented Jan 14, 2026

Could we also please add the clickhouse user's password to be referenced from a secret clickhouse.config.users.appUserPassword. Like suggested here: #125

I think this is a different use case

Copy link
Collaborator

@dhable dhable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. There's a merge conflict, probably around the version, that needs to be resolved. If you revert the Chart.yaml change, it should allow merging in main into your PR branch.

We also would like a changeset in the PR as well. You can create this by running yarn install from the root to install the changeset CLI. Then run yarn changeset and follow the prompts to generate the required files. We can't generate a release without that.

Signed-off-by: Nam Hai Nguyen <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2026

🦋 Changeset detected

Latest commit: 0183a3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
helm-charts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@namm2 namm2 requested a review from dhable January 16, 2026 03:39
Signed-off-by: Nam Hai Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants