West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 1 | Wireframe to Web Code #941
+268
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alizada-dev
added
the
Needs Review
jayshreehajgude2012
added
the
Review in progress
jayshreehajgude2012
left a comment
jayshreehajgude2012
left a comment
There was a problem hiding this comment.
There are some rules which are defined more than once. Some tags are not closed. Nesting of tags can be be improved.
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> |
There was a problem hiding this comment.
duplicate header and its not closed
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| text-align: left; | ||
|
|
There was a problem hiding this comment.
opened the article selector but never closed it.
| > img { | ||
| grid-column: span 3; | ||
| } | ||
| grid-template-columns: repeat(2 ,minmax(0, 1fr)); |
There was a problem hiding this comment.
same rule defines twice
The second one overrides the first
Remove the unused one
jayshreehajgude2012
removed
the
Review in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I added a header, three articles with a title, description, and a link, and a footer. Also, removed some of the CSS styles already in the CSS file and added my own styles.