-
Notifications
You must be signed in to change notification settings - Fork 322
Enable Spark Plan metadata parsing by default #10169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charlesmyu
wants to merge
2
commits into
master
Choose a base branch
from
charles.yu/djm-974/parse-plan-by-default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083591
Total [baseline] (10.804 s) : 0, 10804422
Agent [candidate] (1.086 s) : 0, 1086220
Total [candidate] (10.825 s) : 0, 10824827
section appsec
Agent [baseline] (1.266 s) : 0, 1265543
Total [baseline] (10.903 s) : 0, 10902583
Agent [candidate] (1.269 s) : 0, 1269487
Total [candidate] (10.908 s) : 0, 10907644
section iast
Agent [baseline] (1.224 s) : 0, 1224391
Total [baseline] (11.1 s) : 0, 11099729
Agent [candidate] (1.226 s) : 0, 1225656
Total [candidate] (11.149 s) : 0, 11149094
section profiling
Agent [baseline] (1.206 s) : 0, 1205958
Total [baseline] (10.953 s) : 0, 10953499
Agent [candidate] (1.205 s) : 0, 1204759
Total [candidate] (10.952 s) : 0, 10951903
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (650.445 ms) : 0, 650445
BytebuddyAgent [candidate] (652.236 ms) : 0, 652236
GlobalTracer [baseline] (282.185 ms) : 0, 282185
GlobalTracer [candidate] (282.743 ms) : 0, 282743
AppSec [baseline] (32.597 ms) : 0, 32597
AppSec [candidate] (32.752 ms) : 0, 32752
Debugger [baseline] (68.342 ms) : 0, 68342
Debugger [candidate] (68.402 ms) : 0, 68402
Remote Config [baseline] (642.848 µs) : 0, 643
Remote Config [candidate] (640.313 µs) : 0, 640
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (8.993 ms) : 0, 8993
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.736 ms) : 0, 3736
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (691.862 ms) : 0, 691862
BytebuddyAgent [candidate] (694.547 ms) : 0, 694547
GlobalTracer [baseline] (257.619 ms) : 0, 257619
GlobalTracer [candidate] (258.574 ms) : 0, 258574
AppSec [baseline] (174.855 ms) : 0, 174855
AppSec [candidate] (174.453 ms) : 0, 174453
Debugger [baseline] (66.0 ms) : 0, 66000
Debugger [candidate] (66.734 ms) : 0, 66734
Remote Config [baseline] (767.153 µs) : 0, 767
Remote Config [candidate] (716.186 µs) : 0, 716
Telemetry [baseline] (9.381 ms) : 0, 9381
Telemetry [candidate] (9.294 ms) : 0, 9294
Flare Poller [baseline] (3.657 ms) : 0, 3657
Flare Poller [candidate] (3.684 ms) : 0, 3684
IAST [baseline] (24.776 ms) : 0, 24776
IAST [candidate] (24.792 ms) : 0, 24792
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (792.682 ms) : 0, 792682
BytebuddyAgent [candidate] (793.22 ms) : 0, 793220
GlobalTracer [baseline] (255.413 ms) : 0, 255413
GlobalTracer [candidate] (255.956 ms) : 0, 255956
AppSec [baseline] (33.707 ms) : 0, 33707
AppSec [candidate] (33.579 ms) : 0, 33579
Debugger [baseline] (66.329 ms) : 0, 66329
Debugger [candidate] (66.632 ms) : 0, 66632
Remote Config [baseline] (584.964 µs) : 0, 585
Remote Config [candidate] (604.803 µs) : 0, 605
Telemetry [baseline] (8.56 ms) : 0, 8560
Telemetry [candidate] (8.501 ms) : 0, 8501
Flare Poller [baseline] (3.49 ms) : 0, 3490
Flare Poller [candidate] (3.479 ms) : 0, 3479
IAST [baseline] (26.986 ms) : 0, 26986
IAST [candidate] (26.997 ms) : 0, 26997
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (704.658 ms) : 0, 704658
BytebuddyAgent [candidate] (703.96 ms) : 0, 703960
GlobalTracer [baseline] (220.196 ms) : 0, 220196
GlobalTracer [candidate] (220.104 ms) : 0, 220104
AppSec [baseline] (32.227 ms) : 0, 32227
AppSec [candidate] (32.021 ms) : 0, 32021
Debugger [baseline] (68.056 ms) : 0, 68056
Debugger [candidate] (67.749 ms) : 0, 67749
Remote Config [baseline] (647.368 µs) : 0, 647
Remote Config [candidate] (613.719 µs) : 0, 614
Telemetry [baseline] (8.777 ms) : 0, 8777
Telemetry [candidate] (8.653 ms) : 0, 8653
Flare Poller [baseline] (3.694 ms) : 0, 3694
Flare Poller [candidate] (3.64 ms) : 0, 3640
ProfilingAgent [baseline] (96.686 ms) : 0, 96686
ProfilingAgent [candidate] (97.022 ms) : 0, 97022
Profiling [baseline] (97.268 ms) : 0, 97268
Profiling [candidate] (97.587 ms) : 0, 97587
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091049
Total [baseline] (8.793 s) : 0, 8792687
Agent [candidate] (1.1 s) : 0, 1099812
Total [candidate] (8.803 s) : 0, 8803023
section iast
Agent [baseline] (1.226 s) : 0, 1226165
Total [baseline] (9.334 s) : 0, 9334108
Agent [candidate] (1.223 s) : 0, 1223360
Total [candidate] (9.316 s) : 0, 9315524
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (656.333 ms) : 0, 656333
BytebuddyAgent [candidate] (662.045 ms) : 0, 662045
GlobalTracer [baseline] (283.747 ms) : 0, 283747
GlobalTracer [candidate] (286.211 ms) : 0, 286211
AppSec [baseline] (32.84 ms) : 0, 32840
AppSec [candidate] (33.059 ms) : 0, 33059
Debugger [baseline] (67.759 ms) : 0, 67759
Debugger [candidate] (67.84 ms) : 0, 67840
Remote Config [baseline] (611.964 µs) : 0, 612
Remote Config [candidate] (642.987 µs) : 0, 643
Telemetry [baseline] (9.103 ms) : 0, 9103
Telemetry [candidate] (9.12 ms) : 0, 9120
Flare Poller [baseline] (3.733 ms) : 0, 3733
Flare Poller [candidate] (3.81 ms) : 0, 3810
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (793.396 ms) : 0, 793396
BytebuddyAgent [candidate] (791.596 ms) : 0, 791596
GlobalTracer [baseline] (255.525 ms) : 0, 255525
GlobalTracer [candidate] (255.393 ms) : 0, 255393
AppSec [baseline] (34.76 ms) : 0, 34760
AppSec [candidate] (35.062 ms) : 0, 35062
Debugger [baseline] (65.854 ms) : 0, 65854
Debugger [candidate] (64.795 ms) : 0, 64795
Remote Config [baseline] (610.885 µs) : 0, 611
Remote Config [candidate] (576.595 µs) : 0, 577
Telemetry [baseline] (8.671 ms) : 0, 8671
Telemetry [candidate] (8.584 ms) : 0, 8584
Flare Poller [baseline] (3.526 ms) : 0, 3526
Flare Poller [candidate] (3.449 ms) : 0, 3449
IAST [baseline] (27.088 ms) : 0, 27088
IAST [candidate] (27.18 ms) : 0, 27180
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section baseline
no_agent (18.971 ms) : 18779, 19164
. : milestone, 18971,
appsec (18.664 ms) : 18475, 18854
. : milestone, 18664,
code_origins (17.937 ms) : 17757, 18118
. : milestone, 17937,
iast (17.838 ms) : 17657, 18020
. : milestone, 17838,
profiling (18.608 ms) : 18423, 18794
. : milestone, 18608,
tracing (17.876 ms) : 17690, 18062
. : milestone, 17876,
section candidate
no_agent (19.179 ms) : 18979, 19379
. : milestone, 19179,
appsec (18.497 ms) : 18312, 18683
. : milestone, 18497,
code_origins (17.832 ms) : 17653, 18011
. : milestone, 17832,
iast (18.152 ms) : 17970, 18335
. : milestone, 18152,
profiling (18.606 ms) : 18419, 18794
. : milestone, 18606,
tracing (17.641 ms) : 17467, 17816
. : milestone, 17641,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1212
. : milestone, 1201,
iast (3.129 ms) : 3091, 3168
. : milestone, 3129,
iast_FULL (5.794 ms) : 5737, 5851
. : milestone, 5794,
iast_GLOBAL (3.667 ms) : 3612, 3721
. : milestone, 3667,
profiling (1.912 ms) : 1896, 1928
. : milestone, 1912,
tracing (1.799 ms) : 1784, 1814
. : milestone, 1799,
section candidate
no_agent (1.193 ms) : 1181, 1205
. : milestone, 1193,
iast (3.254 ms) : 3218, 3291
. : milestone, 3254,
iast_FULL (5.863 ms) : 5804, 5922
. : milestone, 5863,
iast_GLOBAL (3.377 ms) : 3328, 3426
. : milestone, 3377,
profiling (1.985 ms) : 1969, 2002
. : milestone, 1985,
tracing (1.839 ms) : 1824, 1854
. : milestone, 1839,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section baseline
no_agent (15.626 s) : 15626000, 15626000
. : milestone, 15626000,
appsec (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
iast (18.601 s) : 18601000, 18601000
. : milestone, 18601000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (14.566 s) : 14566000, 14566000
. : milestone, 14566000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
section candidate
no_agent (15.42 s) : 15420000, 15420000
. : milestone, 15420000,
appsec (14.38 s) : 14380000, 14380000
. : milestone, 14380000,
iast (18.269 s) : 18269000, 18269000
. : milestone, 18269000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.595 s) : 15595000, 15595000
. : milestone, 15595000,
tracing (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~6adfc2c6d6, baseline=1.58.0-SNAPSHOT~88bafa2ade
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.701 ms) : 3480, 3922
. : milestone, 3701,
iast (2.213 ms) : 2148, 2278
. : milestone, 2213,
iast_GLOBAL (2.257 ms) : 2192, 2322
. : milestone, 2257,
profiling (2.088 ms) : 2034, 2143
. : milestone, 2088,
tracing (2.049 ms) : 1997, 2101
. : milestone, 2049,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.726 ms) : 3506, 3945
. : milestone, 3726,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.261 ms) : 2195, 2326
. : milestone, 2261,
profiling (2.05 ms) : 1998, 2103
. : milestone, 2050,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
|
60e96f9 to
5f79e2e
Compare
pawel-big-lebowski
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Enables Spark Plan metadata parsing for all users with Spark instrumentation enabled.
Motivation
This has been tested internally for a month on staging and 2 weeks on prod and seems to be stable. Ship this to all users!
Additional Notes
N/A
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DJM-974