-
Notifications
You must be signed in to change notification settings - Fork 321
Do not break the JMS instrumentation when unable to access a property #10255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amarziali
wants to merge
2
commits into
master
Choose a base branch
from
andrea.marziali/jms-npe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085163
Total [baseline] (10.855 s) : 0, 10854832
Agent [candidate] (1.097 s) : 0, 1096861
Total [candidate] (10.837 s) : 0, 10836538
section appsec
Agent [baseline] (1.275 s) : 0, 1274617
Total [baseline] (10.97 s) : 0, 10969693
Agent [candidate] (1.267 s) : 0, 1266858
Total [candidate] (11.161 s) : 0, 11160751
section iast
Agent [baseline] (1.241 s) : 0, 1240685
Total [baseline] (11.227 s) : 0, 11227242
Agent [candidate] (1.235 s) : 0, 1235201
Total [candidate] (11.251 s) : 0, 11250674
section profiling
Agent [baseline] (1.222 s) : 0, 1222215
Total [baseline] (11.026 s) : 0, 11025741
Agent [candidate] (1.215 s) : 0, 1215289
Total [candidate] (11.168 s) : 0, 11168102
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (651.157 ms) : 0, 651157
BytebuddyAgent [candidate] (655.77 ms) : 0, 655770
GlobalTracer [baseline] (283.328 ms) : 0, 283328
GlobalTracer [candidate] (288.207 ms) : 0, 288207
AppSec [baseline] (32.211 ms) : 0, 32211
AppSec [candidate] (32.907 ms) : 0, 32907
Debugger [baseline] (67.506 ms) : 0, 67506
Debugger [candidate] (69.431 ms) : 0, 69431
Remote Config [baseline] (638.393 µs) : 0, 638
Remote Config [candidate] (650.252 µs) : 0, 650
Telemetry [baseline] (9.194 ms) : 0, 9194
Telemetry [candidate] (9.216 ms) : 0, 9216
Flare Poller [baseline] (4.512 ms) : 0, 4512
Flare Poller [candidate] (3.843 ms) : 0, 3843
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (696.689 ms) : 0, 696689
BytebuddyAgent [candidate] (691.991 ms) : 0, 691991
GlobalTracer [baseline] (260.532 ms) : 0, 260532
GlobalTracer [candidate] (259.359 ms) : 0, 259359
IAST [baseline] (24.89 ms) : 0, 24890
IAST [candidate] (24.672 ms) : 0, 24672
AppSec [baseline] (173.544 ms) : 0, 173544
AppSec [candidate] (172.538 ms) : 0, 172538
Debugger [baseline] (68.55 ms) : 0, 68550
Debugger [candidate] (68.176 ms) : 0, 68176
Remote Config [baseline] (709.236 µs) : 0, 709
Remote Config [candidate] (712.309 µs) : 0, 712
Telemetry [baseline] (8.971 ms) : 0, 8971
Telemetry [candidate] (8.904 ms) : 0, 8904
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (3.766 ms) : 0, 3766
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (802.908 ms) : 0, 802908
BytebuddyAgent [candidate] (798.536 ms) : 0, 798536
GlobalTracer [baseline] (259.227 ms) : 0, 259227
GlobalTracer [candidate] (258.631 ms) : 0, 258631
IAST [baseline] (27.652 ms) : 0, 27652
IAST [candidate] (27.454 ms) : 0, 27454
AppSec [baseline] (33.194 ms) : 0, 33194
AppSec [candidate] (33.032 ms) : 0, 33032
Debugger [baseline] (68.165 ms) : 0, 68165
Debugger [candidate] (68.186 ms) : 0, 68186
Remote Config [baseline] (613.656 µs) : 0, 614
Remote Config [candidate] (590.113 µs) : 0, 590
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.587 ms) : 0, 8587
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.55 ms) : 0, 3550
section profiling
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (713.619 ms) : 0, 713619
BytebuddyAgent [candidate] (707.297 ms) : 0, 707297
GlobalTracer [baseline] (223.673 ms) : 0, 223673
GlobalTracer [candidate] (222.858 ms) : 0, 222858
AppSec [baseline] (32.766 ms) : 0, 32766
AppSec [candidate] (32.499 ms) : 0, 32499
Debugger [baseline] (68.814 ms) : 0, 68814
Debugger [candidate] (68.93 ms) : 0, 68930
Remote Config [baseline] (656.494 µs) : 0, 656
Remote Config [candidate] (629.871 µs) : 0, 630
Telemetry [baseline] (8.894 ms) : 0, 8894
Telemetry [candidate] (8.949 ms) : 0, 8949
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.825 ms) : 0, 3825
ProfilingAgent [baseline] (98.058 ms) : 0, 98058
ProfilingAgent [candidate] (99.212 ms) : 0, 99212
Profiling [baseline] (98.639 ms) : 0, 98639
Profiling [candidate] (99.798 ms) : 0, 99798
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089695
Total [baseline] (8.768 s) : 0, 8767718
Agent [candidate] (1.09 s) : 0, 1090310
Total [candidate] (8.761 s) : 0, 8760746
section iast
Agent [baseline] (1.225 s) : 0, 1225052
Total [baseline] (9.382 s) : 0, 9382454
Agent [candidate] (1.224 s) : 0, 1224470
Total [candidate] (9.349 s) : 0, 9349452
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (655.058 ms) : 0, 655058
BytebuddyAgent [candidate] (655.294 ms) : 0, 655294
GlobalTracer [baseline] (284.028 ms) : 0, 284028
GlobalTracer [candidate] (284.968 ms) : 0, 284968
AppSec [baseline] (32.512 ms) : 0, 32512
AppSec [candidate] (32.507 ms) : 0, 32507
Debugger [baseline] (66.998 ms) : 0, 66998
Debugger [candidate] (66.601 ms) : 0, 66601
Remote Config [baseline] (612.447 µs) : 0, 612
Remote Config [candidate] (628.21 µs) : 0, 628
Telemetry [baseline] (9.107 ms) : 0, 9107
Telemetry [candidate] (9.739 ms) : 0, 9739
Flare Poller [baseline] (4.521 ms) : 0, 4521
Flare Poller [candidate] (3.683 ms) : 0, 3683
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (792.753 ms) : 0, 792753
BytebuddyAgent [candidate] (792.081 ms) : 0, 792081
GlobalTracer [baseline] (256.108 ms) : 0, 256108
GlobalTracer [candidate] (256.316 ms) : 0, 256316
IAST [baseline] (27.02 ms) : 0, 27020
IAST [candidate] (26.984 ms) : 0, 26984
AppSec [baseline] (33.948 ms) : 0, 33948
AppSec [candidate] (35.352 ms) : 0, 35352
Debugger [baseline] (65.946 ms) : 0, 65946
Debugger [candidate] (64.424 ms) : 0, 64424
Remote Config [baseline] (605.747 µs) : 0, 606
Remote Config [candidate] (609.261 µs) : 0, 609
Telemetry [baseline] (8.518 ms) : 0, 8518
Telemetry [candidate] (8.475 ms) : 0, 8475
Flare Poller [baseline] (3.552 ms) : 0, 3552
Flare Poller [candidate] (3.522 ms) : 0, 3522
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section baseline
no_agent (1.194 ms) : 1182, 1206
. : milestone, 1194,
iast (3.107 ms) : 3071, 3143
. : milestone, 3107,
iast_FULL (5.841 ms) : 5782, 5899
. : milestone, 5841,
iast_GLOBAL (3.669 ms) : 3609, 3729
. : milestone, 3669,
profiling (1.977 ms) : 1960, 1994
. : milestone, 1977,
tracing (1.766 ms) : 1752, 1780
. : milestone, 1766,
section candidate
no_agent (1.174 ms) : 1162, 1185
. : milestone, 1174,
iast (3.249 ms) : 3207, 3291
. : milestone, 3249,
iast_FULL (5.905 ms) : 5845, 5965
. : milestone, 5905,
iast_GLOBAL (3.52 ms) : 3470, 3570
. : milestone, 3520,
profiling (2.419 ms) : 2394, 2443
. : milestone, 2419,
tracing (1.784 ms) : 1769, 1799
. : milestone, 1784,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section baseline
no_agent (18.616 ms) : 18426, 18805
. : milestone, 18616,
appsec (19.069 ms) : 18876, 19262
. : milestone, 19069,
code_origins (17.666 ms) : 17490, 17843
. : milestone, 17666,
iast (17.834 ms) : 17655, 18012
. : milestone, 17834,
profiling (18.761 ms) : 18570, 18952
. : milestone, 18761,
tracing (17.72 ms) : 17542, 17898
. : milestone, 17720,
section candidate
no_agent (19.293 ms) : 19097, 19489
. : milestone, 19293,
appsec (19.631 ms) : 19433, 19830
. : milestone, 19631,
code_origins (18.046 ms) : 17870, 18222
. : milestone, 18046,
iast (17.921 ms) : 17741, 18100
. : milestone, 17921,
profiling (18.93 ms) : 18737, 19123
. : milestone, 18930,
tracing (17.91 ms) : 17732, 18089
. : milestone, 17910,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section baseline
no_agent (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
appsec (14.232 s) : 14232000, 14232000
. : milestone, 14232000,
iast (18.367 s) : 18367000, 18367000
. : milestone, 18367000,
iast_GLOBAL (17.723 s) : 17723000, 17723000
. : milestone, 17723000,
profiling (15.403 s) : 15403000, 15403000
. : milestone, 15403000,
tracing (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
section candidate
no_agent (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
appsec (14.589 s) : 14589000, 14589000
. : milestone, 14589000,
iast (18.161 s) : 18161000, 18161000
. : milestone, 18161000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
tracing (14.65 s) : 14650000, 14650000
. : milestone, 14650000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~a956837713, baseline=1.58.0-SNAPSHOT~bcbd429b85
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.737 ms) : 3517, 3957
. : milestone, 3737,
iast (2.221 ms) : 2156, 2285
. : milestone, 2221,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.478 ms) : 2316, 2640
. : milestone, 2478,
tracing (2.049 ms) : 1998, 2100
. : milestone, 2049,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.649 ms) : 3434, 3864
. : milestone, 3649,
iast (2.226 ms) : 2161, 2291
. : milestone, 2226,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.086 ms) : 2032, 2140
. : milestone, 2086,
tracing (2.049 ms) : 1998, 2100
. : milestone, 2049,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: jms
JMS instrumentation
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Solves:
This is caught by the bytebuddy error handler meaning that breaks the jms instrumentation. This PR handle the case more softly
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]