-
Notifications
You must be signed in to change notification settings - Fork 321
Inline yaml component #10268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PerfectSlayer
wants to merge
1
commit into
master
Choose a base branch
from
bbujon/merge-yaml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Inline yaml component #10268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate functionality to config-utils, its only usage.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087328
Total [baseline] (10.787 s) : 0, 10787039
Agent [candidate] (1.088 s) : 0, 1088466
Total [candidate] (10.893 s) : 0, 10892548
section appsec
Agent [baseline] (1.269 s) : 0, 1269002
Total [baseline] (10.891 s) : 0, 10891164
Agent [candidate] (1.276 s) : 0, 1275896
Total [candidate] (10.862 s) : 0, 10862132
section iast
Agent [baseline] (1.225 s) : 0, 1224987
Total [baseline] (11.137 s) : 0, 11137088
Agent [candidate] (1.234 s) : 0, 1234181
Total [candidate] (11.108 s) : 0, 11107877
section profiling
Agent [baseline] (1.207 s) : 0, 1207234
Total [baseline] (10.948 s) : 0, 10948379
Agent [candidate] (1.215 s) : 0, 1214980
Total [candidate] (10.878 s) : 0, 10878204
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (653.35 ms) : 0, 653350
BytebuddyAgent [candidate] (653.844 ms) : 0, 653844
GlobalTracer [baseline] (282.983 ms) : 0, 282983
GlobalTracer [candidate] (283.537 ms) : 0, 283537
AppSec [baseline] (32.589 ms) : 0, 32589
AppSec [candidate] (32.65 ms) : 0, 32650
Debugger [baseline] (68.272 ms) : 0, 68272
Debugger [candidate] (68.012 ms) : 0, 68012
Remote Config [baseline] (607.767 µs) : 0, 608
Remote Config [candidate] (633.354 µs) : 0, 633
Telemetry [baseline] (8.953 ms) : 0, 8953
Telemetry [candidate] (9.219 ms) : 0, 9219
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.859 ms) : 0, 3859
section appsec
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (694.145 ms) : 0, 694145
BytebuddyAgent [candidate] (698.412 ms) : 0, 698412
GlobalTracer [baseline] (258.739 ms) : 0, 258739
GlobalTracer [candidate] (259.901 ms) : 0, 259901
IAST [baseline] (24.634 ms) : 0, 24634
IAST [candidate] (24.932 ms) : 0, 24932
AppSec [baseline] (174.931 ms) : 0, 174931
AppSec [candidate] (174.287 ms) : 0, 174287
Debugger [baseline] (66.056 ms) : 0, 66056
Debugger [candidate] (67.558 ms) : 0, 67558
Remote Config [baseline] (745.35 µs) : 0, 745
Remote Config [candidate] (802.383 µs) : 0, 802
Telemetry [baseline] (9.363 ms) : 0, 9363
Telemetry [candidate] (9.568 ms) : 0, 9568
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.752 ms) : 0, 3752
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (792.737 ms) : 0, 792737
BytebuddyAgent [candidate] (799.613 ms) : 0, 799613
GlobalTracer [baseline] (255.647 ms) : 0, 255647
GlobalTracer [candidate] (257.12 ms) : 0, 257120
IAST [baseline] (27.104 ms) : 0, 27104
IAST [candidate] (27.438 ms) : 0, 27438
AppSec [baseline] (33.554 ms) : 0, 33554
AppSec [candidate] (32.543 ms) : 0, 32543
Debugger [baseline] (66.786 ms) : 0, 66786
Debugger [candidate] (68.069 ms) : 0, 68069
Remote Config [baseline] (573.638 µs) : 0, 574
Remote Config [candidate] (595.394 µs) : 0, 595
Telemetry [baseline] (8.494 ms) : 0, 8494
Telemetry [candidate] (8.551 ms) : 0, 8551
Flare Poller [baseline] (3.495 ms) : 0, 3495
Flare Poller [candidate] (3.457 ms) : 0, 3457
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (705.125 ms) : 0, 705125
BytebuddyAgent [candidate] (710.848 ms) : 0, 710848
GlobalTracer [baseline] (220.891 ms) : 0, 220891
GlobalTracer [candidate] (221.912 ms) : 0, 221912
AppSec [baseline] (32.214 ms) : 0, 32214
AppSec [candidate] (32.399 ms) : 0, 32399
Debugger [baseline] (67.901 ms) : 0, 67901
Debugger [candidate] (68.203 ms) : 0, 68203
Remote Config [baseline] (679.259 µs) : 0, 679
Remote Config [candidate] (673.282 µs) : 0, 673
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.696 ms) : 0, 8696
Flare Poller [baseline] (3.679 ms) : 0, 3679
Flare Poller [candidate] (3.642 ms) : 0, 3642
ProfilingAgent [baseline] (96.962 ms) : 0, 96962
ProfilingAgent [candidate] (97.252 ms) : 0, 97252
Profiling [baseline] (97.555 ms) : 0, 97555
Profiling [candidate] (97.823 ms) : 0, 97823
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089525
Total [baseline] (8.732 s) : 0, 8732402
Agent [candidate] (1.085 s) : 0, 1085219
Total [candidate] (8.722 s) : 0, 8722470
section iast
Agent [baseline] (1.232 s) : 0, 1231615
Total [baseline] (9.298 s) : 0, 9297589
Agent [candidate] (1.222 s) : 0, 1222124
Total [candidate] (9.293 s) : 0, 9292650
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (654.868 ms) : 0, 654868
BytebuddyAgent [candidate] (652.874 ms) : 0, 652874
GlobalTracer [baseline] (283.881 ms) : 0, 283881
GlobalTracer [candidate] (282.631 ms) : 0, 282631
AppSec [baseline] (32.847 ms) : 0, 32847
AppSec [candidate] (32.588 ms) : 0, 32588
Debugger [baseline] (67.817 ms) : 0, 67817
Debugger [candidate] (67.101 ms) : 0, 67101
Remote Config [baseline] (613.805 µs) : 0, 614
Remote Config [candidate] (620.771 µs) : 0, 621
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (8.953 ms) : 0, 8953
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.729 ms) : 0, 3729
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (797.66 ms) : 0, 797660
BytebuddyAgent [candidate] (791.83 ms) : 0, 791830
GlobalTracer [baseline] (256.787 ms) : 0, 256787
GlobalTracer [candidate] (255.44 ms) : 0, 255440
IAST [baseline] (27.456 ms) : 0, 27456
IAST [candidate] (26.964 ms) : 0, 26964
AppSec [baseline] (34.831 ms) : 0, 34831
AppSec [candidate] (34.018 ms) : 0, 34018
Debugger [baseline] (65.35 ms) : 0, 65350
Debugger [candidate] (64.849 ms) : 0, 64849
Remote Config [baseline] (606.655 µs) : 0, 607
Remote Config [candidate] (587.658 µs) : 0, 588
Telemetry [baseline] (8.552 ms) : 0, 8552
Telemetry [candidate] (8.439 ms) : 0, 8439
Flare Poller [baseline] (3.57 ms) : 0, 3570
Flare Poller [candidate] (3.474 ms) : 0, 3474
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (19.523 ms) : 19325, 19720
. : milestone, 19523,
appsec (18.562 ms) : 18374, 18749
. : milestone, 18562,
code_origins (17.681 ms) : 17506, 17856
. : milestone, 17681,
iast (17.676 ms) : 17498, 17853
. : milestone, 17676,
profiling (19.588 ms) : 19393, 19784
. : milestone, 19588,
tracing (17.943 ms) : 17764, 18121
. : milestone, 17943,
section candidate
no_agent (18.075 ms) : 17890, 18260
. : milestone, 18075,
appsec (18.443 ms) : 18256, 18630
. : milestone, 18443,
code_origins (18.07 ms) : 17889, 18251
. : milestone, 18070,
iast (18.049 ms) : 17869, 18229
. : milestone, 18049,
profiling (18.54 ms) : 18355, 18726
. : milestone, 18540,
tracing (17.679 ms) : 17502, 17856
. : milestone, 17679,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.179 ms) : 1168, 1191
. : milestone, 1179,
iast (3.185 ms) : 3143, 3228
. : milestone, 3185,
iast_FULL (5.724 ms) : 5668, 5779
. : milestone, 5724,
iast_GLOBAL (3.692 ms) : 3628, 3756
. : milestone, 3692,
profiling (2.005 ms) : 1987, 2023
. : milestone, 2005,
tracing (1.804 ms) : 1788, 1819
. : milestone, 1804,
section candidate
no_agent (1.17 ms) : 1158, 1181
. : milestone, 1170,
iast (3.169 ms) : 3128, 3210
. : milestone, 3169,
iast_FULL (5.614 ms) : 5560, 5669
. : milestone, 5614,
iast_GLOBAL (3.571 ms) : 3519, 3623
. : milestone, 3571,
profiling (2.028 ms) : 2010, 2045
. : milestone, 2028,
tracing (1.803 ms) : 1787, 1819
. : milestone, 1803,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (15.523 s) : 15523000, 15523000
. : milestone, 15523000,
appsec (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
iast (18.506 s) : 18506000, 18506000
. : milestone, 18506000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
. : milestone, 18055000,
profiling (15.047 s) : 15047000, 15047000
. : milestone, 15047000,
tracing (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
section candidate
no_agent (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
appsec (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
iast (18.032 s) : 18032000, 18032000
. : milestone, 18032000,
iast_GLOBAL (17.804 s) : 17804000, 17804000
. : milestone, 17804000,
profiling (14.666 s) : 14666000, 14666000
. : milestone, 14666000,
tracing (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~97e5b8be51, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (3.761 ms) : 3540, 3982
. : milestone, 3761,
iast (2.237 ms) : 2172, 2303
. : milestone, 2237,
iast_GLOBAL (2.273 ms) : 2207, 2338
. : milestone, 2273,
profiling (2.099 ms) : 2044, 2154
. : milestone, 2099,
tracing (2.057 ms) : 2005, 2108
. : milestone, 2057,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.66 ms) : 3444, 3877
. : milestone, 3660,
iast (2.223 ms) : 2158, 2288
. : milestone, 2223,
iast_GLOBAL (2.27 ms) : 2205, 2336
. : milestone, 2270,
profiling (2.093 ms) : 2040, 2145
. : milestone, 2093,
tracing (2.048 ms) : 1997, 2100
. : milestone, 2048,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: config
Configuration
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR inlines the Yaml platform component into the config-utils module, its only usage.
Motivation
The Yaml module brings 3rd party dependency, has no unit test, and mostly contain a helper around SnakeYaml parser.
It makes more sense to move it where it’s used that trying to re-implement as a standalone Yaml reader.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]