Open
Conversation
fix(unicode): use mb_strtolower
… since Symfony 4.2 and will not be supported anymore in 5.0.
elernonelma
requested changes
Mar 1, 2021
mgiraud
reviewed
Mar 1, 2021
| { | ||
| $treeBuilder = new TreeBuilder(); | ||
| $rootNode = $treeBuilder->root('bilendi_dev_express'); | ||
| $treeBuilder = new TreeBuilder('bilendi_dev_express'); |
Collaborator
There was a problem hiding this comment.
This way of using the first argument of constructor as the root node is a 4.X feature an thus not complient with SF2.X or 3.X, please can you use the same trick as they do in the fosuserbundle : https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/DependencyInjection/Configuration.php#L36
(and sorry for the delay)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge this PR to resolve the Symfony 4.2 user deprecation mentioned in the commit message.