This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Open
Conversation
Closed
eddyb
suggested changes
Aug 14, 2022
Contributor
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
LGTM, modulo the Kernel capabilities and double-checking the generic_const_exprs feature-gate.
Comment on lines
+15
to
+16
| // Ensure kernel capabilities. | ||
| unsafe { asm!("OpCapability Kernel") }; |
Contributor
There was a problem hiding this comment.
Do we have other tests that do this? My understanding was that we've given up on Kernel support (could be wrong though).
Author
There was a problem hiding this comment.
Kernel capability is required for the atomic flag operations. Other test that require specific capabilities are the atomic floats, which I've omitted for the reason that the capability is vendor specific (Nvidia only if I'm correct). The same can be done for the atomic flags tests if required
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed to adding unit-tests for the atomics added in #877
In addition, this PR is also adding atomic flags.