This repository was archived by the owner on Jul 8, 2025. It is now read-only.
feat: Add Capybara::Create and Text::Create#36
Open
Bankokwak wants to merge 7 commits intoExSLMod-Team:masterfrom
Open
feat: Add Capybara::Create and Text::Create#36Bankokwak wants to merge 7 commits intoExSLMod-Team:masterfrom
Bankokwak wants to merge 7 commits intoExSLMod-Team:masterfrom
Conversation
In Text.cs change of Network_collisionsEnabled to CollisionsEnabled. Change to param name for Capybara.cs and Text.cs because he was speakerToy.
louis1706
suggested changes
May 20, 2025
| // </copyright> | ||
| // ----------------------------------------------------------------------- | ||
|
|
||
| #nullable enable |
There was a problem hiding this comment.
no no and no i don't want nullable there reason of why it's not enable in the project
Delete #nullable
(Forget to change that before oupsiii)
louis1706
reviewed
May 21, 2025
Comment on lines
+196
to
+216
| if (PrefabCache<T>.Prefab == null) | ||
| { | ||
| T t = default(T); | ||
| using (Dictionary<uint, GameObject>.ValueCollection.Enumerator enumerator = NetworkClient.prefabs.Values.GetEnumerator()) | ||
| { | ||
| while (enumerator.MoveNext()) | ||
| { | ||
| if (enumerator.Current != null && enumerator.Current.TryGetComponent(out t)) | ||
| { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (t == null) | ||
| { | ||
| throw new InvalidOperationException(string.Format("No prefab in NetworkClient.prefabs has component type {0}", typeof(T))); | ||
| } | ||
|
|
||
| PrefabCache<T>.Prefab = t; | ||
| } |
Author
There was a problem hiding this comment.
without that, the prefab are null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
In Text.cs change of Network_collisionsEnabled to CollisionsEnabled.
Change to param name for Capybara.cs and Text.cs because he was speakerToy.
What is the current behavior? (You can also link to an open issue here)
Name of Network_collisionsEnabled in Text.cs.
Capybara.cs and Text.cs use speakerToy parameters.
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other