This repository was archived by the owner on Jul 8, 2025. It is now read-only.
fix: Shot event not working correctly#39
Draft
Banalny-Banan wants to merge 4 commits intoExSLMod-Team:devfrom
Draft
fix: Shot event not working correctly#39Banalny-Banan wants to merge 4 commits intoExSLMod-Team:devfrom
Banalny-Banan wants to merge 4 commits intoExSLMod-Team:devfrom
Conversation
Author
|
Im working on a transpiler currently |
Author
|
Wasted an hour trying, it still doesnt work, I have more important stuff to do then microoptimize a single method call and quite frankly prefix is more maintainable here |
Author
|
Turned out it can cause an exception and therefore disconnect the client in some conditions I can't consistently reproduce. There is nothing more I can do, im gonna stick with a prefix on a fork. If someone is willing to make a working 1:1 transpiler with a try-catch statement it would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Fixed and updated shot event. Bug report: https://discord.com/channels/656673194693885975/1375077709960581182
What is the current behavior? (You can also link to an open issue here)
🥺👉📉
What is the new behavior? (if this is a feature change)
😊👍
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)