This repository was archived by the owner on Jul 8, 2025. It is now read-only.
feat: Add priority for event handlers to Exiled Events#8
Open
louis1706 wants to merge 4 commits intoExSLMod-Team:devfrom
Open
feat: Add priority for event handlers to Exiled Events#8louis1706 wants to merge 4 commits intoExSLMod-Team:devfrom
louis1706 wants to merge 4 commits intoExSLMod-Team:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Add priority for the eventhandler to the exiled events. This allows the plugin to be the last to handle an event even if the plugin has a high priority and vice versa.
What is the current behavior? (You can also link to an open issue here)
The current behaviour follow the order of ellements added in the inner event. First added first called.
First call the "classic" handler then coroutine handler.
What is the new behavior? (if this is a feature change)
First added first called, when same priority. highest priority, first call.
First call the "classic" handler then coroutine handler, when same priority.
Does this PR introduce a breaking change? no
Other information: I like trains
I didn't test it in game only in unit tests.
I don't care if this pull request get merge or not it's just a draft.
It took me 10 minutes to code it.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other