Extract magic number for user account count to constant #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback to eliminate magic number
3representing user account count. The coding guidelines require all magic numbers be extracted to constants, similar to howMAX_PDP_SP_COUNTis defined.Changes
Added
USER_ACCOUNT_COUNTconstant insrc/constants.rsset to3, representing the number of test user accounts (USER_1, USER_2, USER_3)Replaced 4 hardcoded
3values with the constant across:src/external_api/export.rs: User info export loopsrc/commands/start/usdfc_funding/usdfc_funding_step.rs: Balance checking, token transfer, and verification loopsThis centralizes the user count configuration and improves maintainability.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.