Skip to content

fix(security): fix high severity dev dependencies#1469

Merged
PMerlet merged 7 commits intomainfrom
fix/dev-high-vulnerabilities
Feb 13, 2026
Merged

fix(security): fix high severity dev dependencies#1469
PMerlet merged 7 commits intomainfrom
fix/dev-high-vulnerabilities

Conversation

@PMerlet
Copy link
Contributor

@PMerlet PMerlet commented Feb 12, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Feb 12, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@PMerlet PMerlet force-pushed the fix/dev-high-vulnerabilities branch from 5260a7c to 67f7b96 Compare February 12, 2026 18:51
Remove tar, jws and validator resolutions:
- tar: v6.2.1 and v7.5.7 resolve naturally without forcing v7 on v6 consumers
- jws: v3.2.3 and v4.0.1 resolve naturally without forcing v4 on v3 consumers
- validator: already resolves to 13.15.26 without any override

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Scra3
Copy link
Member

Scra3 commented Feb 13, 2026

Review: Root resolutions cleanup

Resolutions removed (commit 50ec62f)

Resolution Was Issue Fix
tar ^7.5.7 Forced v7 on all tar@^6.x consumers (sqlite3, node-gyp, etc.) — breaking API changes Removed. v6.2.1 and v7.5.7 resolve naturally as separate entries
jws >=4.0.1 Forced v4 on jws@^3.2.2 consumers (@azure/identity via tedious) — different API Removed. v3.2.3 (CVE fix) and v4.0.1 resolve naturally as separate entries
validator >=13.15.22 Redundant — already resolves to 13.15.26 without any override Removed

Resolutions kept (justified)

Resolution Version Why needed
axios >=1.13.5 Fixes CVE-2026-25639, transitive dep resolves to vulnerable 1.12.0 without override
qs >=6.14.1 Fixes CVE-2025-15284, transitive dep pinned to vulnerable 6.13.0
@isaacs/brace-expansion >=5.0.1 Fixes CVE-2026-25547, transitive dep at 5.0.0 without override
lerna/**/glob >=10.5.0 Fixes CVE-2025-64756 (CLI injection), dev-only via lerna
micromatch ^4.0.8 Pre-existing, still needed
semantic-release ^25.0.0 Pre-existing, still needed

Verification

  • Build: 20/20 packages pass
  • Tests: agent (889), forestadmin-client (269), mcp-server (520), ai-proxy (107), datasource-toolkit (457), datasource-customizer (834) — all pass
  • Lockfile: jws v3.2.3 / v4.0.1 and tar v6.2.1 / v7.5.7 resolve as separate entries (no cross-major forcing)
  • Remaining high vulns: 2, both in _example only (fastify v3 / path-to-regexp) — not shipped packages

Additional note

The NestJS bump from v10 to v11 in _example/package.json is inconsistent with packages/agent devDeps which remain at v10. NestJS 11 expects Express 5 by default, but _example still declares express@^4.18.2. Consider aligning or deferring to a separate PR.

@Scra3
Copy link
Member

Scra3 commented Feb 13, 2026

Revert NestJS v11 in _example (commit 01dc7f6)

Reverted @nestjs/* from ^11.0.0 back to ^10.4.16 in _example/package.json.

Why:

  • NestJS 11 is a major upgrade with breaking changes (Express 5 by default, route path syntax changes)
  • _example still declares express@^4.18.2 — incompatible with NestJS 11
  • This bump is unrelated to any CVE — it doesn't belong in a security fix PR
  • packages/agent devDeps remain at NestJS v10, creating an inconsistency

Kept: superagent bump ^10.2.3^10.3.0 (actual security fix, minor version).

The NestJS 11 migration should be done in a dedicated PR with proper testing.

- Remove jws resolution: v3.2.3 and v4.0.1 resolve naturally as
  separate entries, both are safe
- Remove validator resolution: already resolves to 13.15.26 without
  any override
- Keep tar resolution (^7.5.7): yarn v1 deduplication requires it to
  silence audit warnings for lerna transitive deps

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Scra3 Scra3 force-pushed the fix/dev-high-vulnerabilities branch from 01dc7f6 to c31d7b8 Compare February 13, 2026 09:50
@PMerlet PMerlet merged commit dac484e into main Feb 13, 2026
28 checks passed
@PMerlet PMerlet deleted the fix/dev-high-vulnerabilities branch February 13, 2026 10:51
forest-bot added a commit that referenced this pull request Feb 13, 2026
## @forestadmin/ai-proxy [1.4.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/ai-proxy@1.4.2...@forestadmin/ai-proxy@1.4.3) (2026-02-13)

### Bug Fixes

* **security:** fix high severity dev dependencies ([#1469](#1469)) ([dac484e](dac484e))
forest-bot added a commit that referenced this pull request Feb 13, 2026
## @forestadmin/forestadmin-client [1.37.12](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.37.11...@forestadmin/forestadmin-client@1.37.12) (2026-02-13)

### Bug Fixes

* **security:** fix high severity dev dependencies ([#1469](#1469)) ([dac484e](dac484e))

### Dependencies

* **@forestadmin/ai-proxy:** upgraded to 1.4.3
forest-bot added a commit that referenced this pull request Feb 13, 2026
## @forestadmin/agent-client [1.4.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent-client@1.4.7...@forestadmin/agent-client@1.4.8) (2026-02-13)

### Bug Fixes

* **security:** fix high severity dev dependencies ([#1469](#1469)) ([dac484e](dac484e))

### Dependencies

* **@forestadmin/forestadmin-client:** upgraded to 1.37.12
forest-bot added a commit that referenced this pull request Feb 13, 2026
## @forestadmin/mcp-server [1.8.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/mcp-server@1.8.2...@forestadmin/mcp-server@1.8.3) (2026-02-13)

### Bug Fixes

* **security:** fix high severity dev dependencies ([#1469](#1469)) ([dac484e](dac484e))

### Dependencies

* **@forestadmin/agent-client:** upgraded to 1.4.8
* **@forestadmin/forestadmin-client:** upgraded to 1.37.12
forest-bot added a commit that referenced this pull request Feb 13, 2026
## @forestadmin/agent [1.72.9](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.72.8...@forestadmin/agent@1.72.9) (2026-02-13)

### Bug Fixes

* **security:** fix high severity dev dependencies ([#1469](#1469)) ([dac484e](dac484e))

### Dependencies

* **@forestadmin/ai-proxy:** upgraded to 1.4.3
* **@forestadmin/forestadmin-client:** upgraded to 1.37.12
* **@forestadmin/mcp-server:** upgraded to 1.8.3
forest-bot added a commit that referenced this pull request Feb 13, 2026
## @forestadmin/agent-testing [1.0.13](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent-testing@1.0.12...@forestadmin/agent-testing@1.0.13) (2026-02-13)

### Bug Fixes

* **security:** fix high severity dev dependencies ([#1469](#1469)) ([dac484e](dac484e))

### Dependencies

* **@forestadmin/agent-client:** upgraded to 1.4.8
* **@forestadmin/forestadmin-client:** upgraded to 1.37.12
* **@forestadmin/agent:** upgraded to 1.72.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants