Don't accept menu touches when menu is hidden#38
Open
emmavray wants to merge 1 commit intoFriend-LGA:masterfrom
Open
Don't accept menu touches when menu is hidden#38emmavray wants to merge 1 commit intoFriend-LGA:masterfrom
emmavray wants to merge 1 commit intoFriend-LGA:masterfrom
Conversation
This fixes a rather annoying bug where a collapsed (hidden) menu still accepts touches (it's an edge case that I managed to trigger several times). This might not be the most elegant fix, but I just want to bring it to your attention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a rather annoying bug where a collapsed (hidden) menu still accepts touches (it's an edge case that I managed to trigger several times). This might not be the most elegant fix, but I just want to bring it to your attention.