Skip to content

feat(e2e): skip SSM repository deletion and improve creation logging #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-oss-prow merged 1 commit into from
Jan 21, 2026
Merged

feat(e2e): skip SSM repository deletion and improve creation logging #2002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions e2e/nomostest/gitproviders/secure_source_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,11 @@ func (c *SSMClient) CreateRepository(name string) (string, error) {
return fullName, nil
}

// DeleteRepositories calls the gcloud SDK to delete the provided repositories from SSM.
func (c *SSMClient) DeleteRepositories(names ...string) error {
for _, name := range names {
_, err := c.shell.ExecWithDebug("gcloud", "beta", "source-manager", "repos",
"delete", name,
"--region", c.region,
"--project", c.project)
if err != nil {
return fmt.Errorf("deleting source repository: %w", err)
}
}
// DeleteRepositories is a no-op because SSM repo names are determined by the
// test cluster name and RSync namespace and name, so it can be reused if it
// failed to be deleted after the test.
func (c *SSMClient) DeleteRepositories(_ ...string) error {
c.shell.Logger.Info("[SSM] Skip deletion of repos")
return nil
}

Expand Down