Skip to content

Conversation

@vladimyr
Copy link
Contributor

⚠️ DO NOT MERGE

Add jd-gui binary & shimscript.

Depends on java-decompiler/jd-gui#304

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.

Add `jd-gui` binary & shimscript.
@core-code
Copy link
Contributor

whats the plan here? :)

@vladimyr
Copy link
Contributor Author

vladimyr commented Jul 6, 2020

whats the plan here? :)

Why did you assume there is a plan behind my stuff? 🤣

I was trying to achieve the following. I'm using JD-GUI frequently and what I'm forced to do every time is open it and then navigate to jar archive or drag n drop it inside it. Instead, I wanted to simply invoke it inside the terminal and pass target jar but even though there is support for command-line invocation parameters aren't correctly passed. So I started the chain of events:

  1. Raised PR on upstream to fix parameter passing
  2. Prepared HBC PR that adds binary/shim script

As you can see former is still without any reaction from upstream so the latter also hangs becoming sticky part of our PR list...
Frankly, I can either close this ATM or we can continue waiting together for upstream to consider my PR. So no plans, but let's hear your opinion/whishes 😉

@vladimyr
Copy link
Contributor Author

vladimyr commented Jul 6, 2020

Also, note that the last commit to the upstream master is 6mo old. 🤷

@core-code
Copy link
Contributor

ah ok, thanks for the explanation here :)

i'd vote closing this now - we can reopen it anyway iff upstream reacts.

@vladimyr vladimyr closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants