Skip to content

Conversation

@matheuszych
Copy link
Contributor

https://mantis.ilias.de/view.php?id=46561

Aims to fix an error when trying to view ordering table documentation.
@oliversamoila @thojou

@matheuszych
Copy link
Contributor Author

Hello @oliversamoila , Hello @thibsy ,

There are actually two commits. One to fix the issue and one that adds slight typehinting improvements to the renderer.
If you just want the fix, i will revert the improvement changes.

Best regards
@matheuszych

@oliversamoila
Copy link
Contributor

Hello @thibsy
I would like to hand this over to you directly.

Best regards,
Oliver

Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matheuszych,

I appreciate the effort here, but I am hesitant to include the typing change to the renderers for ILIAS 11. Could you please revert this?

LGTM otherwise.

Kind regards,
@thibsy (as UI coordinator)

@matheuszych
Copy link
Contributor Author

matheuszych commented Jan 27, 2026

Hello @thibsy ,
of course. I dropped the commit.

Is it maybe a change we can consider for ILIAS 12?

Best regards
@matheuszych

Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matheuszych thx for the quick reaction. LGTM now!

@thibsy thibsy merged commit df267d5 into ILIAS-eLearning:release_11 Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants