Skip to content

Conversation

@matheuszych
Copy link
Contributor

https://mantis.ilias.de/view.php?id=46528

Aims to fix an error when trying to view ordering table documentation.
@oliversamoila @thojou

@oliversamoila
Copy link
Contributor

Hello @thibsy
I would like to hand this over to you directly.

Best regards,
Oliver

Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matheuszych,

I not exactly sure what we are fixing here. The linked mantis issue should be addressed by providing a description inside the mentioned example (as PHPDoc comment). Is the wrong issue linked?

Kind regards,
@thibsy (as UI coordinator)

@matheuszych
Copy link
Contributor Author

Hello @thibsy ,

From what I understand, the issue is that the "combined_example" button is not working. When clicked, it should display a dropdown menu (or similar element).

The description itself appears to be displayed correctly — it looks the same as in ILIAS 8.

For reference, please compare the two images.

ILIAS 11:
image

ILIAS 8:
image

Best regards
@matheuszych

Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matheuszych,

Thx for the clarification. While you are indeed addressing an issue with the slates, you do not address the linked mantis issue. If I understand https://mantis.ilias.de/view.php?id=46528 and https://mantis.ilias.de/view.php?id=46530 correctly, the test case is blocked and untested because it is not precise enough, due to the missing descriptions on the corresponding example.

Hence, please implement the following changes:

  • Examples: please add a description: > yaml entry inside the PHPDoc comment of the following examples (like with others), which describes that pressing the Slate will reveal more content, and what the abstract content of each of these examples is: Drilldown-Slate, Combined-Slate, Legacy-Slate.

Kind regards,
@thibsy (as UI coordinator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants