ilSessionStatistics prepared statement & Generator #10972
+88
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mBeym
force-pushed
the
feature/ilias11/session/optimization
branch
from
83eb947 to
ab9f2b7
Compare
| * @return Generator<list<array{start_time: int, end_time: ?int, end_context: ?int}>> | ||
| */ | ||
| protected static function getRawData(int $a_begin, int $a_end): array | ||
| protected static function getRawData(int $a_begin, int $a_end): Generator |
Contributor
There was a problem hiding this comment.
Is it possible to use a "Prepared Statement" here as well?
| $raw_data = []; | ||
| while (is_array($slot)) { | ||
| self::aggregateRawHelper($slot[0], $slot[1]); | ||
| $raw_data[] = self::aggregateRawHelper($slot[0], $slot[1]); |
Contributor
There was a problem hiding this comment.
Do we really want to introduce a new buffer for all the aggregated data here?
I think this can lead to a huge amount of memory being allocated.
Since all fields in \ilSessionStatistics::aggregateRawHelper are of type integer, there should not be any problem with using ilDBInterface::prepareManip and ilDBInterface::execute here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accepted should be picked into trunk.