check for invalid header entity#14
Merged
aothms merged 3 commits intoIfcOpenShell:masterfrom May 5, 2025
Merged
Conversation
Member
|
We do have something in ifcopenshell, but indeed if there is a header entity following the three specified ones it doesn't raise an error. Also, this is probably a better place to do that check. https://github.com/IfcOpenShell/IfcOpenShell/blob/d401e4c948482c02d789a890f897b6929928f504/src/ifcparse/IfcSpfHeader.cpp#L94-L110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header entity can only be FILE_DESCRIPTION, FILE_NAME or FILE_SCHEMA. Encountered a file with FILE_INFO, which doesn't give a fail somewhere else.
e.g. ifcopenshell.validate
After these changes
For the validation service, this will cause the file to fail before reaching the header validation.