Iss930 Kalman code for incorporating ECAL energy information into track fits#992
Open
robertprestonjohnson wants to merge 22 commits intomasterfrom
Open
Iss930 Kalman code for incorporating ECAL energy information into track fits#992robertprestonjohnson wants to merge 22 commits intomasterfrom
robertprestonjohnson wants to merge 22 commits intomasterfrom
Conversation
…ugging code to KalmanToGBLDriver
A Driver used to refit ReconstructedParticles by including the energy of the associated ECal cluster in the track fit. A new ReconstructedParticle collection is added to the event.
…o iss930 Incorporate a new driver template added by Norman for adding ECAL constraint to SVT tracks.
Collaborator
Author
|
See presentation at recent HPS collaboration meeting: https://indico.slac.stanford.edu/event/8012/contributions/6023/ |
normangraf
approved these changes
May 23, 2023
Contributor
normangraf
left a comment
normangraf
left a comment
There was a problem hiding this comment.
Adds new functionality, shouldn't affect existing reconstruction.
Please proceed.
cbravo135
reviewed
Jun 5, 2023
| fm = det.getFieldMap(); | ||
| /* | ||
| System.out.format("B field map vs y:\n"); | ||
|
|
Collaborator
There was a problem hiding this comment.
It appears to me lines 204 through 226 are for printing the b-field for debugging purposes. It was commented out before, can we do that again, or add a debug parameter to make it configurable to dump this info and make the default to not print this all out to stdout?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 930
New driver ReconstructedParticleRefitter and code in the Kalman package to facilitate refitting tracks read back from the DST, including options to remove layers and to incorporate the ECAL energy information into the Kalman track fit.