Added support for --mode json-file, removed all unwraps, added better error handling#18
Open
joshterrill wants to merge 1 commit intoJulien-R44:mainfrom
Open
Added support for --mode json-file, removed all unwraps, added better error handling#18joshterrill wants to merge 1 commit intoJulien-R44:mainfrom
--mode json-file, removed all unwraps, added better error handling#18joshterrill wants to merge 1 commit intoJulien-R44:mainfrom
Conversation
Author
|
I also saw that there weren't any tests in the project, I was going to take some of the examples and turn them into rust tests so that it can easily be run through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I'm using this binary in a project and saw that the docs say json was supported, but the code didn't actually implement it. So I've taken the liberty of doing so, as well as removing all of the
.unwrap()'s where the program was often panicking due to errors, so there should be much better error handling now, graceful exits, and better messaging.