Add CMake 4 support by updating min cmake versions and policies #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update cmake_minimum_required from 3.3.0 to 3.10 in root CMakeLists.txt - Add CMAKE_POLICY_VERSION_MINIMUM=3.10 to COMMON_CMAKE_ARGS - Add Windows-specific CMP0091 policy for MSVC runtime library - Update Patches/Boost/Common.cmake to require CMake 3.10 These changes prepare fletch for CMake 4 compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Patches/CppDB/CMakeLists.txt: 2.6 -> 3.10 - Patches/PostgreSQL/CMakeLists.txt: 2.8 -> 3.10 - Patches/PostgreSQL/Patch.cmake: Add cmake_minimum_required to generated file - Patches/libsvm/CMakeLists.txt: 3.3 -> 3.16.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add patches for VTK 8.0, 8.2, 9.0, and 9.5 to fix CMake 4 compatibility. The main issue is that cmake_policy(SET CMP0022 OLD) is no longer supported in CMake 4. These patches replace the vtklibproj4 policies.cmake file to set CMP0022 to NEW instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add patch for vxl_shared_link_test CMakeLists.txt to fix CMake 4 compatibility. The original file had cmake_minimum_required version that was too old for CMake 4. The patched file updates the minimum version to 3.10 and sets appropriate policies for newer CMake versions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- libjpeg-turbo: Remove cmake_policy(SET CMP0022 OLD)
- libgeotiff: Remove cmake_policy(SET CMP0022 OLD) and CMP0042 OLD
- x265: Remove cmake_policy(SET CMP0025 OLD) and CMP0054 OLD
- yasm: Update cmake_minimum_required to 3.10, fix LOCATION property
usage (CMP0026) by replacing with generator expressions
These policies can no longer be set to OLD in CMake 4.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- External_CppDB.cmake: Use COMMON_CMAKE_ARGS for consistency - External_libgeotiff.cmake: Add PATCH_COMMAND to apply new patch - External_yasm.cmake: Add PATCH_COMMAND and use COMMON_CMAKE_ARGS This wires up the new CMake 4 compatibility patches to be applied during the build process. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.