Added new method to allow the user to decide if they want to retrieve the profile or not#44
Open
shaivilp wants to merge 3 commits intoLitarvan:masterfrom
Open
Added new method to allow the user to decide if they want to retrieve the profile or not#44shaivilp wants to merge 3 commits intoLitarvan:masterfrom
shaivilp wants to merge 3 commits intoLitarvan:masterfrom
Conversation
Fixes issue with unable to login into minecraft accounts without a username set such as giftcard and gamepass accounts
Added javadocs for loginWithCredentials(String email, String password, boolean retrieveProfile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
These commits add a new function / method loginWithCredentials(String email, String password, boolean retrieveProfile)
this method can be used for minecraft accounts without a username set such as giftcards or gamepass accounts it returns the MicrosoftAuthResult with the MinecraftProfile set to null