Skip to content

Conversation

@coleleavitt
Copy link

@coleleavitt coleleavitt commented Dec 5, 2025

Description

Skip Nvidia cards if we're looking for VAAPI devices. This is important for hybrid GPU laptops where the display may be connected through NVIDIA but rendering happens on Intel.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copilot AI review requested due to automatic review settings December 5, 2025 17:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds logic to skip NVIDIA graphics cards when searching for VAAPI-capable devices in KMS (Kernel Mode Setting) display capture. This is particularly important for hybrid GPU laptops where the display may be connected through an NVIDIA GPU but hardware encoding should occur on the Intel/AMD GPU that supports VAAPI.

Key Changes

  • Added NVIDIA card filtering for VAAPI device enumeration in two critical locations within kmsgrab.cpp
  • The filtering occurs during both display initialization and display name enumeration
  • Debug logging added to track when NVIDIA cards are being skipped for VAAPI

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@ReenigneArcher
Copy link
Member

Thank you for the PR! I think this should target the master branch instead of the feature branch that was selected. Is it okay if I change the base branch?

@coleleavitt
Copy link
Author

Thank you for the PR! I think this should target the master branch instead of the feature branch that was selected. Is it okay if I change the base branch?

yea go right ahead thank you

@ReenigneArcher ReenigneArcher changed the base branch from feat/linux/add-xdg-portal-grab to master December 6, 2025 20:15
@ReenigneArcher
Copy link
Member

Thank you for the PR! I think this should target the master branch instead of the feature branch that was selected. Is it okay if I change the base branch?

yea go right ahead thank you

Looks like that didn't quite work. Can you rebase your branch so it's based on our master branch?

@ReenigneArcher ReenigneArcher changed the base branch from master to feat/linux/add-xdg-portal-grab December 15, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants