Fix test duplicate references in group #4580
Open
+59
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects list This will prevent duplicating replace logic when replacing in scene.mobjects and in the ancestors of the mobject
…ps when replacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Modifies the
Scence.replacefunction to replace the mobject with its replacements in both the scene and the Groups/VGroups it belongs to.The main
replacelogic has been moved into another function named_replaceto make this part more reusable.You can check the test passing using
uv run pytest tests/module/animation/test_transform.pyMotivation and Explanation: Why and how do your changes improve the library?
This was done to fix the test
test_duplicate_references_in_multiple_groupsthat was failing. Also, now the functionality works as described in thereplacedocstring.Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist